Skip to content

Publish S3 backend container image#38

Merged
nickamzol merged 3 commits intoUMEssen:mainfrom
paulkre:s3-feature-image
Oct 20, 2025
Merged

Publish S3 backend container image#38
nickamzol merged 3 commits intoUMEssen:mainfrom
paulkre:s3-feature-image

Conversation

@paulkre
Copy link
Contributor

@paulkre paulkre commented Oct 15, 2025

This pull request modifies the CI pipeline to publish a separate container image ghcr.io/umessen/dicom-rst-s3:vX.X.X which has the S3 backend feature enabled.

Copy link
Member

@nickamzol nickamzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request regarding the image version, otherwise this looks good to me.

I think we should introduce a -full image just for convenience if you want to try out all available backends.

  • -full with all features enabled
  • -s3 with the S3 feature enabled
  • -dimse in the future when we make the DIMSE backend optional.

The removal of cargo-chef will increase the build time, but I understand that there are some issues with distroless images and TLS introduced by the S3 dependencies. Nothing critical though - we can always improve it later on.

@paulkre
Copy link
Contributor Author

paulkre commented Oct 20, 2025

I agree that we should publish a full version of the image with all features. I would even argue, we don't necessarily have to publish any images other than the full version. If users want specialized images with a subset of features, they can always build their own image. But I chose this solution because I wasn't sure yet, whether the S3 backend is ready for production use.

But even if we want to publish additional images, we should do this in a separate PR, in my opinion.

@nickamzol nickamzol merged commit e332866 into UMEssen:main Oct 20, 2025
@paulkre paulkre deleted the s3-feature-image branch October 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants