dependencies: remove all non-dev dependencies from root in favor of package deps #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrice32
requested review from
daywiss,
kendricktan,
nicholaspai and
chrismaree
and removed request for
daywiss,
kendricktan,
nicholaspai and
chrismaree
mrice32
requested review from
chrismaree,
nicholaspai,
kendricktan and
daywiss
nicholaspai
approved these changes
Aug 10, 2020
mrice32
requested review from
a team and
daywiss
and removed request for
chrismaree,
kendricktan,
daywiss and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most of these dependencies were already copied down into the packages that needed them. All deps that were needed at the root level for miscellaneous ci processes and scripts were moved to dev dependencies.
Summary
Almost all root dependencies were removed.
Issue(s)
Fixes #1823