migrate to ethers v6 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reinis-FRP
reviewed
Feb 13, 2024
| @@ -165,11 +165,11 @@ export function useOgDeployer(initialConfig?: Partial<OgDeployerConfig>) { | |||
| return undefined; | |||
| } | |||
|
|
|||
| return () => { | |||
| return async () => { | |||
There was a problem hiding this comment.
this now results in returning async deploy function while activateOsnap in OsnapCard expects synchronous call. This results in build failing
Reinis-FRP
approved these changes
Feb 13, 2024
Signed-off-by: david <david@umaproject.org>
|
this isnt quite working yet based on my testing, not sure whats going on yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
To integrate Core network, we need ot update gosis/zodiac package. Zodia's new version depends on ethers v6, which will break this app. This PR migrates to using ethers v6 and gnosis/zodianc v4.
NOTE:
We can only merge this PR After