Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in recently raised issues (capsule support, default torch device bug, and mujoco dependency) #41

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

StoneT2000
Copy link
Contributor

@StoneT2000 StoneT2000 changed the title Bug fixes Fix some bugs in recently raised issues (capsule support, default torch device bug, and mujoco dependency) Aug 15, 2024
@LemonPi
Copy link
Member

LemonPi commented Aug 19, 2024

Hi, thank you for your contribution! I just defended my thesis and so should have more time to maintain the code. I agree that Mujoco shouldn't be a hard dependency. However the mjcf parts should work if Mujoco is installed (see the package failing messages above). I think the best way is to add a line in .github/workflows/python-package.yml to pip install mujoco.

(I'll make the change if you don't respond within a week)

@LemonPi LemonPi merged commit 403e1a6 into UM-ARM-Lab:master Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants