Skip to content
This repository was archived by the owner on Jun 29, 2019. It is now read-only.

Cdmp 2344 #1

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Cdmp 2344 #1

merged 4 commits into from
Jun 12, 2019

Conversation

nefischer
Copy link
Contributor

Code to create an S3 bucket to hold performance testing data.
Supporting IAM policies and roles are also created to allow management of the objects in the bucket

name: perf-test-inspec
title: InSpec Profile for AWS performance testing resources
maintainer: nicolas.fischer@digital.homeoffice.gov.uk
copyright: UK Home Office
Copy link

@daniel-ac-martin daniel-ac-martin Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crown copyright

Or

Crown copyright (Home Office, Digital, Data and Technology)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright amended to the latter option

Copy link

@daniel-ac-martin daniel-ac-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (apart from copyright )but I'm no python expert!

@nefischer nefischer merged commit fbecebb into master Jun 12, 2019
@nefischer nefischer deleted the CDMP-2344 branch June 12, 2019 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants