Repository navigation
fix(ui5-tokenizer): proper calculation of tokenizer overflow width - #14105
Open
nikoletavnv wants to merge 1 commit into
Open
nikoletavnv wants to merge 1 commit into
nikoletavnv wants to merge 1 commit into
Conversation
|
🚀 Deployed on https://pr-14105--ui5-webcomponents-preview.netlify.app |
Vonahz
self-requested a review
October 1, 2026 11:34
Vonahz
requested changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
I found two issues:
- With this change, there is case when the tokenizer is cut on the right side:
To reproduce this issue, set first token of many to "And" and set width of tokenizer to "109px"
- In RTL page we still have the issue as the fix takes always the right side of the tokenizer.
| const boundaryRect = boundaryDom.getBoundingClientRect(); | ||
| const parentRect = this.contentDom.getBoundingClientRect(); | ||
| const parentEnd = Number(parentRect.right.toFixed(2)); | ||
| const parentEnd = Number(boundaryRect.right.toFixed(2)); |
Contributor
There was a problem hiding this comment.
Both are named parent* but they measure two different DOM nodes. That's the core naming lie — a reader reasonably assumes parentStart/parentEnd are the two edges of the same "parent" container.
| // For the last token, check if it fits without "n more" | ||
| // For other tokens, check if token + "n more" fits together | ||
| const effectiveParentEnd = isLastToken ? parentEnd : Number((parentRect.right - nMoreWidth).toFixed(2)); | ||
| const effectiveParentEnd = isLastToken ? parentEnd : Number((boundaryRect.right - nMoreWidth).toFixed(2)); |
Contributor
There was a problem hiding this comment.
Also here instead of parentEnd we need something like rootEnd
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14067