Skip to content

chore(ui5-navigation-layout): delete unnecessary item-click event #13161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LidiyaGeorgieva merged 2 commits into from
Feb 26, 2026
+0 −12
Merged

chore(ui5-navigation-layout): delete unnecessary item-click event #13161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa600f3
fix(ui5-navigation-layout): delete unnecessary item-click event
LidiyaGeorgieva Feb 26, 2026
e65a3c4
chore: fix lint error
LidiyaGeorgieva Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/fiori/src/NavigationLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
import customElement from "@ui5/webcomponents-base/dist/decorators/customElement.js";
import event from "@ui5/webcomponents-base/dist/decorators/event-strict.js";
import property from "@ui5/webcomponents-base/dist/decorators/property.js";
import slot from "@ui5/webcomponents-base/dist/decorators/slot-strict.js";
import jsxRenderer from "@ui5/webcomponents-base/dist/renderer/JsxRenderer.js";
Expand Down Expand Up @@ -56,17 +55,6 @@ const SCREEN_WIDTH_BREAKPOINT = 600;
template: NavigationLayoutTemplate,
})

/**
* Fired when an item is clicked.
*
* @param {SideNavigationSelectableItemBase} item The clicked item.
* @public
*/
@event("item-click", {
bubbles: true,
cancelable: true,
})

class NavigationLayout extends UI5Element {
eventDetails!: {
"item-click": SideNavigationItemClickEventDetail
Expand Down
Loading