feat(ui5-time-picker): display-value and value-format properties are introduced#13071
Open
feat(ui5-time-picker): display-value and value-format properties are introduced#13071
Conversation
Collaborator
|
🚀 Deployed on https://pr-13071--ui5-webcomponents-preview.netlify.app |
hinzzx
requested changes
Feb 17, 2026
packages/website/docs/_samples/main/TimePicker/CustomFormatting/sample.html
Outdated
Show resolved
Hide resolved
hinzzx
approved these changes
Feb 19, 2026
tsanislavgatev
requested changes
Feb 25, 2026
packages/main/src/TimePicker.ts
Outdated
Contributor
There was a problem hiding this comment.
Fix documentation here as well, I did it in ui5-date-picker
packages/main/src/TimePicker.ts
Outdated
| _isoFormatInstance?: DateFormat; | ||
| _displayFormatInstance?: DateFormat; | ||
| _valueFormatInstance?: DateFormat; | ||
| _lastDisplayFormatPattern?: string; |
Contributor
There was a problem hiding this comment.
why do we need this?
packages/main/src/TimePicker.ts
Outdated
| _displayFormatInstance?: DateFormat; | ||
| _valueFormatInstance?: DateFormat; | ||
| _lastDisplayFormatPattern?: string; | ||
| _lastValueFormatPattern?: string; |
Contributor
There was a problem hiding this comment.
why do we need this?
packages/main/src/TimePicker.ts
Outdated
| let parsedValue = this.getValueFormat().parse(this.value, true); | ||
| if (!parsedValue) { | ||
| // If it doesn't parse as valueFormat, try displayFormat | ||
| parsedValue = this.getDisplayFormat().parse(this.value, true); |
Contributor
There was a problem hiding this comment.
the flow should be valueFormat->formatPattern->iso, the display format should not be a fallback format
packages/main/src/TimePicker.ts
Outdated
|
|
||
| // @ts-ignore oFormatOptions is a private API of DateFormat | ||
| return this.getFormat().oFormatOptions.pattern as string; | ||
| return this.getISOFormat().oFormatOptions.pattern as string; |
Contributor
There was a problem hiding this comment.
display default should be "medium", not ISO
packages/main/src/TimePicker.ts
Outdated
| } | ||
|
|
||
| // Try to parse as valueFormat and display in displayFormat | ||
| const parsedValue = this.getValueFormat().parse(this.value, true); |
Contributor
There was a problem hiding this comment.
we should always have a display format, either set by the application or with formatpattern or with ISO
Comment on lines
871
to
897
| return this.getISOFormat(); | ||
| } | ||
|
|
||
| const pattern = this._valueFormat; | ||
|
|
||
| // Return cached instance if pattern hasn't changed | ||
| if (this._valueFormatInstance && this._lastValueFormatPattern === pattern) { | ||
| return this._valueFormatInstance; | ||
| } | ||
|
|
||
| this._lastValueFormatPattern = pattern; | ||
|
|
||
| if (this._isValueFormatPattern) { | ||
| this._valueFormatInstance = DateFormat.getTimeInstance({ | ||
| strictParsing: true, | ||
| pattern: this._valueFormat, | ||
| }); | ||
| } else { | ||
| this._valueFormatInstance = DateFormat.getTimeInstance({ | ||
| strictParsing: true, | ||
| style: this._valueFormat, | ||
| }); | ||
| } | ||
|
|
||
| return this._valueFormatInstance; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
we should simplify this
packages/main/src/TimePicker.ts
Outdated
Comment on lines
845
to
866
| const pattern = this._displayFormat; | ||
|
|
||
| // Return cached instance if pattern hasn't changed | ||
| if (this._displayFormatInstance && this._lastDisplayFormatPattern === pattern) { | ||
| return this._displayFormatInstance; | ||
| } | ||
|
|
||
| this._lastDisplayFormatPattern = pattern; | ||
|
|
||
| if (this._isDisplayFormatPattern) { | ||
| this._displayFormatInstance = DateFormat.getTimeInstance({ | ||
| strictParsing: true, | ||
| pattern: this._displayFormat, | ||
| }); | ||
| } else { | ||
| this._displayFormatInstance = DateFormat.getTimeInstance({ | ||
| strictParsing: true, | ||
| style: this._displayFormat, | ||
| }); | ||
| } | ||
|
|
||
| return this._displayFormatInstance; |
Contributor
There was a problem hiding this comment.
We should simplify this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces display-value and value-format properties to the ui5-time-picker component
Changes: