feat(ui5-rating-indicator): custom rating icon implemantation#12985
Open
feat(ui5-rating-indicator): custom rating icon implemantation#12985
Conversation
BGSOFUIRILA-4212
restore deleted files
Collaborator
|
🚀 Deployed on https://pr-12985--ui5-webcomponents-preview.netlify.app |
Vonahz
requested changes
Jan 30, 2026
apply code review feedback
…P/ui5-webcomponents into rating-indicator-custom-icons
MapTo0
previously approved these changes
Feb 3, 2026
MapTo0
dismissed
their stale review
waiting Milen's opinion on that I am good
Vonahz
approved these changes
Feb 4, 2026
refactor half-icon visualization
Contributor
|
I reviewed the recent changes—everything looks good. One suggestion: the classes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BGSOFUIRILA-4212