feat(ui5-color-picker): add accessibleName property for unique landmarks#12968
Open
feat(ui5-color-picker): add accessibleName property for unique landmarks#12968
accessibleName property for unique landmarks#12968Conversation
accessibleName property for unique landmarks
Collaborator
|
🚀 Deployed on https://pr-12968--ui5-webcomponents-preview.netlify.app |
unazko
approved these changes
Jan 29, 2026
nnaydenow
reviewed
Feb 2, 2026
Contributor
|
I've tested the
Also the code looks clean. |
accessibleName property for unique landmarksaccessibleName property for unique landmarks
tsanislavgatev
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently with our
ui5-color-pickerif multiple color picker instances on a page all have the same "Color Picker" label for theirrole="group"landmark, violating WCAG 2.2 requirement that landmarks must have unique role/label combinationsSolutions
accessibleNameproperty:sectiontodiv<section>is a semantic landmark element (like<nav>,<main>,<aside>)<section>withrole="group"creates conflicting semantics<div>withrole="group"is the correct, non-landmark approach