Skip to content

fix(AnalyticalTable - TypeScript): remove legacy overloads in AnalyticalTableColumnDefinition #7827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

fix(AnalyticalTable - TypeScript): remove legacy overloads in AnalyticalTableColumnDefinition #7827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/main/src/components/AnalyticalTable/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export interface AnalyticalTableColumnDefinition {
/**
* Can either be string or a React component that will be rendered as column header
*/
Header?: string | ComponentType<any> | ((props?: any) => ReactNode);
Header?: string | ComponentType<any>;
/**
* Defines the `aria-label` for the whole column read by screen readers.
*
Expand All @@ -433,15 +433,15 @@ export interface AnalyticalTableColumnDefinition {
* __Note:__ Using a custom component __can impact performance__!
* If you pass a component, __memoizing it is strongly recommended__, especially for complex components or large datasets.
*/
Cell?: string | ComponentType<CellInstance> | ((props?: CellInstance) => ReactNode);
Cell?: string | ComponentType<CellInstance>;
/**
* Defines a function that receives an object as a parameter, including the cell and table instance, and should return the `aria-label` of the current cell.
*
* __Note:__ Use this property if there is no textual content available through the dataset (e.g. no `accessor` field available), or if you want to provide additional context when navigating to the respective cell for screen readers.
*
* __Note:__ To retrieve the internal `aria-label`, utilize the `cell.cellLabel` property.
*/
cellLabel?: (param?: CellLabelParam) => string;
cellLabel?: (param: CellLabelParam) => string;
/**
* Defines the column width. If not set the table will distribute all columns without a width evenly.
*
Expand Down Expand Up @@ -475,7 +475,7 @@ export interface AnalyticalTableColumnDefinition {
/**
* Filter Component to be rendered in the Header.
*/
Filter?: ComponentType<FilterProps> | ((props: FilterProps) => ReactNode);
Filter?: ComponentType<FilterProps>;
/**
* Disable filters for this column.
*/
Expand Down Expand Up @@ -507,7 +507,7 @@ export interface AnalyticalTableColumnDefinition {
/**
* Component to render for aggregated cells.
*/
Aggregated?: string | ComponentType<any> | ((props?: any) => ReactNode);
Aggregated?: string | ComponentType<any>;
/**
* Aggregation function or string.<br />Supported String Values: <ul><li>`min`</li><li>`max`</li><li>`median`</li><li>`count`</li></ul>
*/
Expand Down Expand Up @@ -601,7 +601,7 @@ export interface AnalyticalTableColumnDefinition {
/**
* Custom pop-in header renderer. If set, the table will call that component for every column that is "popped-in" and pass the table instance as prop.
*/
PopInHeader?: string | ComponentType<any> | ((props?: any) => ReactNode);
PopInHeader?: string | ComponentType<any>;
/**
* Defines the display of `AnalyticalTable` pop-ins.
*
Expand Down