Skip to content

docs(Dialog): enable F6 navigation & add footer Bar #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

docs(Dialog): enable F6 navigation & add footer Bar #7807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd92ee9
docs(Dialog): enable F6 navigation
Lukas742 Oct 7, 2025
a9f9c41
replace FlexBox with Bar in footer
Lukas742 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions packages/main/src/webComponents/Dialog/Dialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { isChromatic } from '@sb/utils.js';
import type { Meta, StoryObj } from '@storybook/react-vite';
import { FlexBox, FlexBoxJustifyContent } from '@ui5/webcomponents-react';
import { useEffect, useState } from 'react';
import { Bar } from '../Bar/index.js';
import { Button, List, ListItemStandard } from '../index.js';
import { Dialog } from './index.js';

Expand Down Expand Up @@ -47,21 +47,27 @@ export const Default: Story = {
</Button>
<Dialog
{...args}
data-sap-ui-fastnavgroup="true"
className="contentPartNoPadding footerPartNoPadding"
open={dialogOpen}
onClose={(e) => {
args.onClose(e);
setDialogOpen(false);
}}
footer={
<FlexBox justifyContent={FlexBoxJustifyContent.End} fitContainer style={{ paddingBlock: '0.25rem' }}>
<Button
onClick={() => {
setDialogOpen(false);
}}
>
Close
</Button>
</FlexBox>
<Bar
design="Footer"
endContent={
<Button
data-sap-ui-fastnavgroup="true"
onClick={() => {
setDialogOpen(false);
}}
>
Close
</Button>
}
/>
}
/>
</>
Expand Down
Loading