Skip to content

fix(AnalyticalTable - useF2CellEdit): support interactive Icon #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(AnalyticalTable - useF2CellEdit): support interactive Icon #7782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import type {
TextAreaDomRef,
TimePickerDomRef,
ToggleButtonDomRef,
IconDomRef,
} from '../..';
import {
AnalyticalTable,
Expand All @@ -51,6 +52,7 @@ import {
DynamicDateRange,
FileUploader,
IndicationColor,
Icon,
Input,
MessageViewButton,
MultiComboBox,
Expand Down Expand Up @@ -4103,19 +4105,29 @@ describe('AnalyticalTable', () => {
cy.realPress('ArrowDown');

cy.realPress('F2');
allRelevantInputCompontentsForF2.forEach((_) => {
allRelevantInputCompontentsForF2.forEach((col) => {
cy.log(col.Header);
if (col.id === 'segmented-button') {
// SegmentedButton has two tab stops
cy.realPress('Tab');
}
cy.realPress('F2');
cy.focused().should('have.attr', 'role', 'gridcell');
cy.realPress('F2');
cy.realPress('Tab');
});
// SegmentedButton has two tab stops
cy.realPress('Tab');

cy.focused().should('have.text', 'After');

cy.realPress('F2');
allRelevantInputCompontentsForF2.forEach((_) => {
cy.realPress(['Shift', 'Tab']);
allRelevantInputCompontentsForF2.forEach((col) => {
if (col.id === 'segmented-button') {
// SegmentedButton has two tab stops
cy.realPress(['Shift', 'Tab']);
}
cy.realPress(['Shift', 'Tab']);
});
// SegmentedButton has two tab stops
cy.realPress(['Shift', 'Tab']);
cy.focused().should('have.text', 'Before');
});

Expand Down Expand Up @@ -6016,6 +6028,14 @@ const allRelevantInputCompontentsForF2 = [
interactiveElementName: 'FileUploader',
tagName: 'ui5-file-uploader',
},
{
Header: 'Icon',
Cell: (props: AnalyticalTableCellInstance) => {
const callbackRef = useF2CellEdit.useCallbackRef<IconDomRef>(props);
return <Icon name="employee" mode="Interactive" ref={callbackRef} />;
},
interactiveElementName: 'Icon',
},
{
Header: 'Input',
id: 'input',
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/components/AnalyticalTable/pluginHooks/useF2CellEdit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const NON_STANDARD_INTERACTIVE_ELEMENTS = [
'[ui5-segmented-button]',
'[ui5-select]',
'[ui5-slider]',
'[ui5-split-button]',
'[ui5-icon][mode="Interactive"]',
];

/**
Expand Down