-
Notifications
You must be signed in to change notification settings - Fork 105
fix(Assets): remove top-level await
#7741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top-level await for '@ui5/webcomponents-fiori/dist/Assets.js', causes runtime errors in Next.js App Router and could also break Pages Router during SSR or build-time module evaluation.
|
Size Change: -185 B (-0.04%) Total Size: 444 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 17546610791Details
💛 - Coveralls |
Collaborator
|
🎉 This PR is included in version v2.14.1 🎉 The release is available on v2.14.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level await for
@ui5/webcomponents-fiori/dist/Assets.js, causes runtime errors in Next.js App Router and could also break Pages Router during SSR or build-time module evaluation.