Skip to content

fix(VariantManagemen): removed unused prop enabled #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix(VariantManagemen): removed unused prop enabled #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/DayPicker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<DayPicker>
<ui5-daypicker class="" />
Expand Down
6 changes: 3 additions & 3 deletions packages/main/__karma_snapshots__/FilterBar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<FilterBar renderSearch={[Function: renderSearch]} renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
<div className="FilterBar-outerContainer---">
<div className="FilterBar-filterBarHeader---">
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
<div style={{...}} onClick={[Function]}>
<div className="Variant-Management--VariantManagement---">
Expand Down Expand Up @@ -125,7 +125,7 @@
<FilterBar renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
<div className="FilterBar-outerContainer---">
<div className="FilterBar-filterBarHeader---">
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
<div style={{...}} onClick={[Function]}>
<div className="Variant-Management--VariantManagement---">
Expand Down Expand Up @@ -249,7 +249,7 @@
<FilterBar renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
<div className="FilterBar-outerContainer---">
<div className="FilterBar-filterBarHeader---">
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
<div style={{...}} onClick={[Function]}>
<div className="Variant-Management--VariantManagement---">
Expand Down
6 changes: 3 additions & 3 deletions packages/main/__karma_snapshots__/VariantManagement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
<div style={{...}} onClick={[Function]}>
<div className="Variant-Management--VariantManagement---">
Expand All @@ -29,8 +29,8 @@
</Button>
<WithWebComponent(List) onItemClick={[Function]} mode="SingleSelect" headerText="" footerText="" noDataText="" separators="All">
<ui5-list mode="SingleSelect" header-text="" footer-text="" no-data-text="" separators="All" class="">
<StandardListItem style={{...}} data-key="1" type="Active" selected={false} infoState="None">
<ui5-li style={{...}} data-key="1" type="Active" info-state="None" class="">
<StandardListItem style={{...}} data-key="1" type="Active" selected={true} infoState="None">
<ui5-li selected={true} style={{...}} data-key="1" type="Active" info-state="None" class="">
Variant 1
</ui5-li>
</StandardListItem>
Expand Down
2 changes: 0 additions & 2 deletions packages/main/src/components/VariantManagement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export interface VariantItem {
}

export interface VariantManagementPropTypes extends CommonProps {
enabled?: boolean;
placement?: PlacementType;
popupTitle?: string;
initialSelectedKey?: string;
Expand Down Expand Up @@ -185,7 +184,6 @@ const VariantManagement: FC<VariantManagementPropTypes> = forwardRef(
);

VariantManagement.defaultProps = {
enabled: true,
popupTitle: 'Variants',
initialSelectedKey: null,
onSelect: () => {},
Expand Down