Skip to content

fix(cra-template): fix test to be successful #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

fix(cra-template): fix test to be successful #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cra-template/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"@ui5/webcomponents": "1.0.0-rc.7",
"@ui5/webcomponents-fiori": "1.0.0-rc.7",
"@ui5/webcomponents-icons": "1.0.0-rc.7",
"@ui5/webcomponents-react": "^0.9.0",
"@ui5/webcomponents-react": "^0.9.4",
"@testing-library/react": "^9.3.2",
"@testing-library/jest-dom": "^4.2.4",
"@testing-library/user-event": "^7.1.2",
Expand Down
34 changes: 21 additions & 13 deletions packages/cra-template/template/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
import { ThemeProvider } from '@ui5/webcomponents-react/lib/ThemeProvider';
import {
FlexBox,
FlexBoxAlignItems,
FlexBoxDirection,
FlexBoxJustifyContent,
Link,
LinkDesign,
ShellBar,
ThemeProvider
} from '@ui5/webcomponents-react';
import React from 'react';
import './App.css';
import logo from './logo.svg';

function App() {
return (
<ThemeProvider>
<div className="App">
<header className="App-header">
<img src={logo} className="App-logo" alt="logo" />
<p>
Edit <code>src/App.js</code> and save to reload.
</p>
<a className="App-link" href="https://reactjs.org" target="_blank" rel="noopener noreferrer">
Learn React
</a>
</header>
</div>
<ShellBar primaryTitle="UI5 Web Components for React Template" />
<FlexBox
style={{ width: '100%', height: '100vh' }}
direction={FlexBoxDirection.Column}
justifyContent={FlexBoxJustifyContent.Center}
alignItems={FlexBoxAlignItems.Center}
>
<Link href="https://sap.github.io/ui5-webcomponents-react/" target="_blank" design={LinkDesign.Emphasized}>
Getting Started with UI5 Web Component for React
</Link>
</FlexBox>
</ThemeProvider>
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template/template/src/App.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ import App from './App';

test('renders learn react link', () => {
const { getByText } = render(<App />);
const linkElement = getByText(/learn react/i);
const linkElement = getByText(/Getting Started with UI5 Web Component for React/i);
expect(linkElement).toBeInTheDocument();
});