Analytical table #23
Merged
Analytical table #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/fiori3/package.json # packages/fiori3/src/components/ResponsivePopover/index.tsx # packages/fiori3/src/webComponents/Popover/index.tsx # yarn.lock
…older and run index script
MarcusNotheis
requested changes
May 27, 2019
| @@ -0,0 +1,102 @@ | |||
| import React from 'react'; | |||
| import { AnalyticalTable as Table } from './index'; | |||
Contributor
There was a problem hiding this comment.
is there any reason why you rename the import to Table? If not I would go for Analytical Table.
Please also import from ../../lib/AnalyticalTable
| @@ -0,0 +1,132 @@ | |||
| // import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
If this test does nothing, please delete the file
packages/fiori3/src/components/AnalyticalTable/AnalyticalTable.karma.tsx
Show resolved
Hide resolved
| @@ -0,0 +1,176 @@ | |||
| import React, { Component, ReactNode, ReactNodeArray } from 'react'; | |||
| import { ClassProps } from '../../../interfaces/ClassProps'; | |||
| import { Icon } from '../../../webComponents/Icon'; | |||
Contributor
There was a problem hiding this comment.
please import from lib
| @@ -0,0 +1,46 @@ | |||
| import { fonts } from '@fiori-for-react/styles'; | |||
| import { ContentDensity } from '../../../enums/ContentDensity'; | |||
| @@ -0,0 +1,25 @@ | |||
| import React, { FC, isValidElement, ReactNode, ReactText } from 'react'; | |||
| import { Title } from '../../../webComponents/Title'; | |||
| /** The background color of lists. */ | ||
| export const sapUiListBackground = '#ffffff'; | ||
| /** The background color of the column header area of lists. */ | ||
| export const sapUiListHeaderBackground = HSLColor.of(sapUiListBackground).darken(5); |
Contributor
There was a problem hiding this comment.
please add a .hsl after darken(5)
MarcusNotheis
requested changes
Jun 7, 2019
| @@ -0,0 +1,111 @@ | |||
| import React from 'react'; | |||
| import { AnalyticalTable } from './index'; | |||
Contributor
There was a problem hiding this comment.
``
Suggested change
| import { AnalyticalTable } from './index'; | |
| import { AnalyticalTable } from '../../lib/AnalyticalTable'; |
packages/fiori3/src/components/AnalyticalTable/columnHeaderModal/index.tsx
Outdated
Show resolved
Hide resolved
| import { boolean, number } from '@storybook/addon-knobs'; | ||
| import { AnalyticalTable as Table } from '../index'; | ||
| import generateData from './generateData'; | ||
| import { Title } from '../../../webComponents/Title'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { Title } from '../../../webComponents/Title'; | |
| import { Title } from '../../../lib/Title'; |
| import React from 'react'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { boolean, number } from '@storybook/addon-knobs'; | ||
| import { AnalyticalTable } from '../index'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { AnalyticalTable } from '../index'; | |
| import { AnalyticalTable } from '../../lib/AnalyticalTable'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist