Skip to content

Conversation

@Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented Nov 3, 2021

This PR adds the portalContainer prop to components wich are using React.createPortal to render modals or other elements outside of the DOM hierarchy. With portalContainer it is possible to change the element the modal is rendered into.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Size Change: +91 B (0%)

Total Size: 238 kB

Filename Size Change
packages/main/dist/ActionSheet.js 2.75 kB +18 B (+1%)
packages/main/dist/AnalyticalTable.js 27.5 kB +63 B (0%)
packages/main/dist/FilterBar.js 8.59 kB -66 B (-1%)
packages/main/dist/ObjectPage.js 12.9 kB +18 B (0%)
packages/main/dist/Toolbar.js 3.49 kB +33 B (+1%)
packages/main/dist/VariantManagement.js 7.42 kB +25 B (0%)
ℹ️ View Unchanged
Filename Size
packages/base/dist/CssSizeVariables.js 1.03 kB
packages/base/dist/Device.js 2.92 kB
packages/base/dist/hooks.js 2.17 kB
packages/base/dist/spacing.js 1.01 kB
packages/base/dist/StyleClassHelper.js 678 B
packages/base/dist/ThemingParameters.js 3.6 kB
packages/base/dist/useConsolidatedRef.js 258 B
packages/base/dist/usePassThroughHtmlProps.js 331 B
packages/base/dist/useViewportRange.js 405 B
packages/base/dist/Utils.js 1.06 kB
packages/charts/dist/BarChart.js 4.86 kB
packages/charts/dist/BarChartPlaceholder.js 459 B
packages/charts/dist/BulletChart.js 5.68 kB
packages/charts/dist/BulletChartPlaceholder.js 794 B
packages/charts/dist/ColumnChart.js 4.8 kB
packages/charts/dist/ColumnChartPlaceholder.js 514 B
packages/charts/dist/ColumnChartWithTrend.js 2.56 kB
packages/charts/dist/ColumnChartWithTrendPlaceholder.js 601 B
packages/charts/dist/components/ChartContainer.js 1.79 kB
packages/charts/dist/components/ChartDataLabel.js 625 B
packages/charts/dist/components/XAxisTicks.js 698 B
packages/charts/dist/components/YAxisTicks.js 596 B
packages/charts/dist/ComposedChart.js 5.56 kB
packages/charts/dist/ComposedChartPlaceholder.js 878 B
packages/charts/dist/DonutChart.js 3.25 kB
packages/charts/dist/LineChart.js 4.42 kB
packages/charts/dist/LineChartPlaceholder.js 529 B
packages/charts/dist/MicroBarChart.js 2.08 kB
packages/charts/dist/PieChart.js 3.13 kB
packages/charts/dist/PieChartPlaceholder.js 445 B
packages/charts/dist/RadarChart.js 2.39 kB
packages/charts/dist/RadialChart.js 1.44 kB
packages/charts/dist/ScatterChart.js 4.07 kB
packages/charts/dist/ScatterChartPlaceholder.js 536 B
packages/charts/dist/useLegendItemClick.js 395 B
packages/charts/dist/Utils.js 787 B
packages/main/dist/AnalyticalCard.js 840 B
packages/main/dist/AnalyticalCardHeader.js 2.46 kB
packages/main/dist/AnalyticalTableHooks.js 1.83 kB
packages/main/dist/AnalyticalTableScrollMode.js 177 B
packages/main/dist/Assets-static.js 56 B
packages/main/dist/Assets.js 49 B
packages/main/dist/assets/i18n/i18n-defaults.js 1.44 kB
packages/main/dist/Avatar.js 556 B
packages/main/dist/AvatarColorScheme.js 269 B
packages/main/dist/AvatarGroup.js 594 B
packages/main/dist/AvatarGroupType.js 212 B
packages/main/dist/AvatarShape.js 208 B
packages/main/dist/AvatarSize.js 219 B
packages/main/dist/Badge.js 450 B
packages/main/dist/Bar.js 527 B
packages/main/dist/BarcodeScannerDialog.js 614 B
packages/main/dist/BarDesign.js 226 B
packages/main/dist/Breadcrumbs.js 599 B
packages/main/dist/BreadcrumbsDesign.js 227 B
packages/main/dist/BreadcrumbsItem.js 345 B
packages/main/dist/BreadcrumbsSeparatorStyle.js 266 B
packages/main/dist/BusyIndicator.js 525 B
packages/main/dist/BusyIndicatorSize.js 223 B
packages/main/dist/Button.js 466 B
packages/main/dist/ButtonDesign.js 254 B
packages/main/dist/Calendar.js 661 B
packages/main/dist/CalendarDate.js 332 B
packages/main/dist/CalendarSelection.js 163 B
packages/main/dist/CalendarSelectionMode.js 242 B
packages/main/dist/CalendarType.js 212 B
packages/main/dist/Card.js 510 B
packages/main/dist/CardHeader.js 466 B
packages/main/dist/Carousel.js 588 B
packages/main/dist/CarouselArrowsPlacement.js 241 B
packages/main/dist/CheckBox.js 604 B
packages/main/dist/ColorPalette.js 365 B
packages/main/dist/ColorPaletteItem.js 335 B
packages/main/dist/ColorPicker.js 365 B
packages/main/dist/ComboBox.js 568 B
packages/main/dist/ComboBoxGroupItem.js 367 B
packages/main/dist/ComboBoxItem.js 333 B
packages/main/dist/ContentDensity.js 151 B
packages/main/dist/CustomListItem.js 456 B
packages/main/dist/DatePicker.js 606 B
packages/main/dist/DateRangePicker.js 559 B
packages/main/dist/DateTimePicker.js 582 B
packages/main/dist/DeviationIndicator.js 160 B
packages/main/dist/Dialog.js 723 B
packages/main/dist/DynamicPage.js 5.14 kB
packages/main/dist/DynamicPageHeader.js 1.36 kB
packages/main/dist/DynamicPageTitle.js 2.65 kB
packages/main/dist/FCLLayout.js 280 B
packages/main/dist/FileUploader.js 685 B
packages/main/dist/FilterGroupItem.js 1.49 kB
packages/main/dist/FlexBox.js 1.03 kB
packages/main/dist/FlexBoxAlignItems.js 189 B
packages/main/dist/FlexBoxDirection.js 169 B
packages/main/dist/FlexBoxJustifyContent.js 194 B
packages/main/dist/FlexBoxWrap.js 154 B
packages/main/dist/FlexibleColumnLayout.js 524 B
packages/main/dist/Form.js 2.82 kB
packages/main/dist/FormGroup.js 720 B
packages/main/dist/FormItem.js 1.54 kB
packages/main/dist/GlobalStyleClasses.js 151 B
packages/main/dist/Grid.js 2 kB
packages/main/dist/GridPosition.js 157 B
packages/main/dist/GroupHeaderListItem.js 380 B
packages/main/dist/GrowingMode.js 225 B
packages/main/dist/Icon.js 655 B
packages/main/dist/IllustratedMessage.js 690 B
packages/main/dist/IllustrationMessageType.js 330 B
packages/main/dist/IndicationColor.js 279 B
packages/main/dist/Input.js 833 B
packages/main/dist/InputType.js 235 B
packages/main/dist/json-imports/i18n-static.js 1.06 kB
packages/main/dist/json-imports/i18n.js 963 B
packages/main/dist/Label.js 597 B
packages/main/dist/Link.js 531 B
packages/main/dist/LinkDesign.js 224 B
packages/main/dist/List.js 778 B
packages/main/dist/ListGrowingMode.js 229 B
packages/main/dist/ListItemType.js 217 B
packages/main/dist/ListMode.js 266 B
packages/main/dist/ListSeparators.js 241 B
packages/main/dist/Loader.js 1.42 kB
packages/main/dist/LoaderType.js 152 B
packages/main/dist/MessageBox.js 3.2 kB
packages/main/dist/MessageBoxActions.js 209 B
packages/main/dist/MessageBoxTypes.js 204 B
packages/main/dist/MessageItem.js 1.75 kB
packages/main/dist/MessageStrip.js 516 B
packages/main/dist/MessageStripDesign.js 243 B
packages/main/dist/MessageView.js 2.74 kB
packages/main/dist/MessageViewContext.js 167 B
packages/main/dist/MultiComboBox.js 715 B
packages/main/dist/MultiComboBoxItem.js 365 B
packages/main/dist/MultiInput.js 724 B
packages/main/dist/NotificationAction.js 420 B
packages/main/dist/NotificationListGroupItem.js 613 B
packages/main/dist/NotificationListItem.js 674 B
packages/main/dist/ObjectPageMode.js 159 B
packages/main/dist/ObjectPageSection.js 1.55 kB
packages/main/dist/ObjectPageSubSection.js 1.46 kB
packages/main/dist/ObjectStatus.js 1.78 kB
packages/main/dist/Option.js 369 B
packages/main/dist/Page.js 477 B
packages/main/dist/PageBackgroundDesign.js 216 B
packages/main/dist/Panel.js 487 B
packages/main/dist/PanelAccessibleRole.js 234 B
packages/main/dist/Popover.js 652 B
packages/main/dist/PopoverHorizontalAlign.js 256 B
packages/main/dist/PopoverPlacementType.js 234 B
packages/main/dist/PopoverVerticalAlign.js 248 B
packages/main/dist/Priority.js 219 B
packages/main/dist/ProductSwitch.js 375 B
packages/main/dist/ProductSwitchItem.js 422 B
packages/main/dist/ProgressIndicator.js 431 B
packages/main/dist/RadioButton.js 593 B
packages/main/dist/RangeSlider.js 504 B
packages/main/dist/RatingIndicator.js 445 B
packages/main/dist/ResponsiveGridLayout.js 1.18 kB
packages/main/dist/ResponsivePopover.js 616 B
packages/main/dist/SegmentedButton.js 476 B
packages/main/dist/SegmentedButtonItem.js 511 B
packages/main/dist/Select.js 449 B
packages/main/dist/SemanticColor.js 237 B
packages/main/dist/ShellBar.js 543 B
packages/main/dist/ShellBarItem.js 375 B
packages/main/dist/SideNavigation.js 609 B
packages/main/dist/SideNavigationItem.js 413 B
packages/main/dist/SideNavigationSubItem.js 374 B
packages/main/dist/Size.js 151 B
packages/main/dist/Slider.js 494 B
packages/main/dist/StandardListItem.js 521 B
packages/main/dist/StepInput.js 615 B
packages/main/dist/SuggestionGroupItem.js 362 B
packages/main/dist/SuggestionItem.js 431 B
packages/main/dist/Switch.js 611 B
packages/main/dist/SwitchDesign.js 208 B
packages/main/dist/Tab.js 475 B
packages/main/dist/TabContainer.js 495 B
packages/main/dist/TabLayout.js 211 B
packages/main/dist/Table.js 705 B
packages/main/dist/TableCell.js 332 B
packages/main/dist/TableColumn.js 401 B
packages/main/dist/TableGroupRow.js 325 B
packages/main/dist/TableGrowingMode.js 230 B
packages/main/dist/TableMode.js 231 B
packages/main/dist/TablePlaceholder.js 799 B
packages/main/dist/TableRow.js 360 B
packages/main/dist/TableRowType.js 207 B
packages/main/dist/TableScaleWidthMode.js 169 B
packages/main/dist/TableSelectionBehavior.js 165 B
packages/main/dist/TableSelectionMode.js 164 B
packages/main/dist/TableVisibleRowCountMode.js 177 B
packages/main/dist/TabSeparator.js 338 B
packages/main/dist/Text.js 950 B
packages/main/dist/TextAlign.js 183 B
packages/main/dist/TextArea.js 650 B
packages/main/dist/ThemeProvider.js 956 B
packages/main/dist/Themes.js 188 B
packages/main/dist/Timeline.js 602 B
packages/main/dist/TimelineItem.js 361 B
packages/main/dist/TimelineLayout.js 213 B
packages/main/dist/TimePicker.js 540 B
packages/main/dist/Title.js 393 B
packages/main/dist/TitleLevel.js 233 B
packages/main/dist/Toast.js 415 B
packages/main/dist/ToastPlacement.js 286 B
packages/main/dist/ToggleButton.js 646 B
packages/main/dist/Token.js 379 B
packages/main/dist/ToolbarDesign.js 175 B
packages/main/dist/ToolbarSeparator.js 616 B
packages/main/dist/ToolbarSpacer.js 348 B
packages/main/dist/ToolbarStyle.js 153 B
packages/main/dist/Tree.js 417 B
packages/main/dist/TreeItem.js 457 B
packages/main/dist/UploadCollection.js 481 B
packages/main/dist/UploadCollectionItem.js 529 B
packages/main/dist/UploadState.js 211 B
packages/main/dist/ValueState.js 182 B
packages/main/dist/VariantItem.js 703 B
packages/main/dist/VariantManagementContext.js 174 B
packages/main/dist/VerticalAlign.js 174 B
packages/main/dist/withWebComponent.js 1.82 kB
packages/main/dist/Wizard.js 444 B
packages/main/dist/WizardStep.js 469 B
packages/main/dist/WrappingType.js 242 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 3, 2021

Pull Request Test Coverage Report for Build 1416525439

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.45%

Totals Coverage Status
Change from base Build 1415849003: 0.0%
Covered Lines: 3294
Relevant Lines: 4146

💛 - Coveralls

@Lukas742 Lukas742 merged commit e71b663 into main Nov 3, 2021
@Lukas742 Lukas742 deleted the feat/portals branch November 3, 2021 11:52
@ui5-webcomponents-react-bot
Copy link
Collaborator

🎉 This PR is included in version v0.19.0 🎉

The release is available on v0.19.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants