Skip to content

fix(FilterBar): only display toolbar separator & overflow button when necessary #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

fix(FilterBar): only display toolbar separator & overflow button when necessary #1570

merged 2 commits into from
May 11, 2021

Conversation

@Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented May 11, 2021 •
edited
Loading

  • Don't show toolbar separator if variants is not set

  • Don't show overflow button if no buttons are displayed

@Lukas742
fix(FilterBar): don't show toolbar separator if variants is not set, …
3f4c13b 
…don't show overflow button if no buttons are displayed
@Lukas742 Lukas742 requested a review from MarcusNotheis as a code owner May 11, 2021 09:29
@Lukas742 Lukas742 changed the title fix(FilterBar): don't show toolbar separator if variants is not set, don't show overflow button if no buttons are displayed fix(FilterBar): don't show toolbar separator if variants is not set, don't show overflow button if no buttons are displayed May 11, 2021
@github-actions
Copy link

github-actions bot commented May 11, 2021 •
edited
Loading

Size Change: +31 B (0%)

Total Size: 197 kB

Filename Size Change
packages/main/dist/FilterBar.js 7.18 kB +31 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/base/dist/CssSizeVariables.js 959 B 0 B
packages/base/dist/Device.js 4.78 kB 0 B
packages/base/dist/hooks.js 1.74 kB 0 B
packages/base/dist/Logger.js 1.22 kB 0 B
packages/base/dist/spacing.js 999 B 0 B
packages/base/dist/StyleClassHelper.js 637 B 0 B
packages/base/dist/ThemingParameters.js 3.6 kB 0 B
packages/base/dist/useConsolidatedRef.js 271 B 0 B
packages/base/dist/usePassThroughHtmlProps.js 327 B 0 B
packages/base/dist/useViewportRange.js 431 B 0 B
packages/base/dist/Utils.js 783 B 0 B
packages/charts/dist/BarChart.js 4.18 kB 0 B
packages/charts/dist/BarChartPlaceholder.js 459 B 0 B
packages/charts/dist/ColumnChart.js 4.41 kB 0 B
packages/charts/dist/ColumnChartPlaceholder.js 514 B 0 B
packages/charts/dist/components/ChartContainer.js 1.52 kB 0 B
packages/charts/dist/components/ChartDataLabel.js 605 B 0 B
packages/charts/dist/components/XAxisTicks.js 617 B 0 B
packages/charts/dist/components/YAxisTicks.js 514 B 0 B
packages/charts/dist/ComposedChart.js 5.13 kB 0 B
packages/charts/dist/ComposedChartPlaceholder.js 878 B 0 B
packages/charts/dist/DonutChart.js 3.19 kB 0 B
packages/charts/dist/LineChart.js 4.26 kB 0 B
packages/charts/dist/LineChartPlaceholder.js 529 B 0 B
packages/charts/dist/MicroBarChart.js 2.09 kB 0 B
packages/charts/dist/PieChart.js 3.07 kB 0 B
packages/charts/dist/PieChartPlaceholder.js 445 B 0 B
packages/charts/dist/RadarChart.js 2.36 kB 0 B
packages/charts/dist/RadialChart.js 1.4 kB 0 B
packages/charts/dist/ScatterChart.js 4.05 kB 0 B
packages/charts/dist/ScatterChartPlaceholder.js 536 B 0 B
packages/charts/dist/useLegendItemClick.js 395 B 0 B
packages/charts/dist/Utils.js 436 B 0 B
packages/main/dist/ActionSheet.js 2.56 kB 0 B
packages/main/dist/AnalyticalCard.js 859 B 0 B
packages/main/dist/AnalyticalCardHeader.js 2.61 kB 0 B
packages/main/dist/AnalyticalTable.js 24.2 kB 0 B
packages/main/dist/AnalyticalTableHooks.js 1.73 kB 0 B
packages/main/dist/AnalyticalTableScrollMode.js 177 B 0 B
packages/main/dist/Assets-static.js 56 B 0 B
packages/main/dist/Assets.js 49 B 0 B
packages/main/dist/assets/i18n/i18n-defaults.js 923 B 0 B
packages/main/dist/Avatar.js 592 B 0 B
packages/main/dist/AvatarBackgroundColor.js 219 B 0 B
packages/main/dist/AvatarFitType.js 151 B 0 B
packages/main/dist/AvatarGroup.js 618 B 0 B
packages/main/dist/AvatarGroupType.js 155 B 0 B
packages/main/dist/AvatarShape.js 150 B 0 B
packages/main/dist/AvatarSize.js 155 B 0 B
packages/main/dist/Badge.js 449 B 0 B
packages/main/dist/Bar.js 432 B 0 B
packages/main/dist/BarDesign.js 169 B 0 B
packages/main/dist/Breadcrumbs.js 1.6 kB 0 B
packages/main/dist/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/dist/BusyIndicator.js 447 B 0 B
packages/main/dist/BusyIndicatorSize.js 167 B 0 B
packages/main/dist/Button.js 471 B 0 B
packages/main/dist/ButtonDesign.js 190 B 0 B
packages/main/dist/Calendar.js 659 B 0 B
packages/main/dist/CalendarDate.js 254 B 0 B
packages/main/dist/CalendarSelection.js 163 B 0 B
packages/main/dist/CalendarSelectionMode.js 167 B 0 B
packages/main/dist/CalendarType.js 212 B 0 B
packages/main/dist/Card.js 484 B 0 B
packages/main/dist/Carousel.js 541 B 0 B
packages/main/dist/CarouselArrowsPlacement.js 166 B 0 B
packages/main/dist/CheckBox.js 590 B 0 B
packages/main/dist/ColorPalette.js 379 B 0 B
packages/main/dist/ColorPaletteItem.js 344 B 0 B
packages/main/dist/ColorPicker.js 334 B 0 B
packages/main/dist/ComboBox.js 554 B 0 B
packages/main/dist/ComboBoxItem.js 332 B 0 B
packages/main/dist/ContentDensity.js 151 B 0 B
packages/main/dist/CustomListItem.js 448 B 0 B
packages/main/dist/DatePicker.js 593 B 0 B
packages/main/dist/DateRangePicker.js 545 B 0 B
packages/main/dist/DateTimePicker.js 568 B 0 B
packages/main/dist/DeviationIndicator.js 160 B 0 B
packages/main/dist/Dialog.js 714 B 0 B
packages/main/dist/DurationPicker.js 603 B 0 B
packages/main/dist/DynamicPage.js 4.38 kB 0 B
packages/main/dist/DynamicPageHeader.js 1.44 kB 0 B
packages/main/dist/DynamicPageTitle.js 1.62 kB 0 B
packages/main/dist/FCLLayout.js 236 B 0 B
packages/main/dist/FileUploader.js 683 B 0 B
packages/main/dist/FilterGroupItem.js 1.26 kB 0 B
packages/main/dist/FlexBox.js 1.08 kB 0 B
packages/main/dist/FlexBoxAlignItems.js 189 B 0 B
packages/main/dist/FlexBoxDirection.js 169 B 0 B
packages/main/dist/FlexBoxJustifyContent.js 194 B 0 B
packages/main/dist/FlexBoxWrap.js 154 B 0 B
packages/main/dist/FlexibleColumnLayout.js 520 B 0 B
packages/main/dist/Form.js 2.77 kB 0 B
packages/main/dist/FormGroup.js 712 B 0 B
packages/main/dist/FormItem.js 1.21 kB 0 B
packages/main/dist/GlobalStyleClasses.js 151 B 0 B
packages/main/dist/Grid.js 2.02 kB 0 B
packages/main/dist/GridPosition.js 157 B 0 B
packages/main/dist/GroupHeaderListItem.js 370 B 0 B
packages/main/dist/Icon.js 655 B 0 B
packages/main/dist/Input.js 827 B 0 B
packages/main/dist/InputType.js 184 B 0 B
packages/main/dist/json-imports/i18n-static.js 1.06 kB 0 B
packages/main/dist/json-imports/i18n.js 963 B 0 B
packages/main/dist/Label.js 571 B 0 B
packages/main/dist/Link.js 518 B 0 B
packages/main/dist/LinkDesign.js 191 B 0 B
packages/main/dist/List.js 729 B 0 B
packages/main/dist/ListGrowingMode.js 164 B 0 B
packages/main/dist/ListItemTypes.js 160 B 0 B
packages/main/dist/ListMode.js 191 B 0 B
packages/main/dist/ListSeparators.js 186 B 0 B
packages/main/dist/Loader.js 1.45 kB 0 B
packages/main/dist/LoaderType.js 152 B 0 B
packages/main/dist/MessageBox.js 2.56 kB 0 B
packages/main/dist/MessageBoxActions.js 231 B 0 B
packages/main/dist/MessageBoxTypes.js 232 B 0 B
packages/main/dist/MessageStrip.js 510 B 0 B
packages/main/dist/MessageStripType.js 181 B 0 B
packages/main/dist/MultiComboBox.js 720 B 0 B
packages/main/dist/MultiComboBoxItem.js 364 B 0 B
packages/main/dist/MultiInput.js 725 B 0 B
packages/main/dist/NotificationAction.js 419 B 0 B
packages/main/dist/NotificationListGroupItem.js 596 B 0 B
packages/main/dist/NotificationListItem.js 653 B 0 B
packages/main/dist/ObjectPage.js 9.98 kB 0 B
packages/main/dist/ObjectPageMode.js 159 B 0 B
packages/main/dist/ObjectPageSection.js 1.29 kB 0 B
packages/main/dist/ObjectPageSubSection.js 1.19 kB 0 B
packages/main/dist/ObjectStatus.js 1.23 kB 0 B
packages/main/dist/Option.js 368 B 0 B
packages/main/dist/Page.js 476 B 0 B
packages/main/dist/PageBackgroundDesign.js 184 B 0 B
packages/main/dist/Panel.js 487 B 0 B
packages/main/dist/PanelAccessibleRoles.js 201 B 0 B
packages/main/dist/PlacementType.js 175 B 0 B
packages/main/dist/Popover.js 640 B 0 B
packages/main/dist/PopoverHorizontalAlign.js 181 B 0 B
packages/main/dist/PopoverPlacementType.js 172 B 0 B
packages/main/dist/PopoverVerticalAlign.js 204 B 0 B
packages/main/dist/Priority.js 163 B 0 B
packages/main/dist/ProductSwitch.js 374 B 0 B
packages/main/dist/ProductSwitchItem.js 422 B 0 B
packages/main/dist/ProgressIndicator.js 433 B 0 B
packages/main/dist/RadioButton.js 588 B 0 B
packages/main/dist/RangeSlider.js 502 B 0 B
packages/main/dist/RatingIndicator.js 438 B 0 B
packages/main/dist/ResponsivePopover.js 605 B 0 B
packages/main/dist/SegmentedButton.js 474 B 0 B
packages/main/dist/Select.js 433 B 0 B
packages/main/dist/SemanticColor.js 181 B 0 B
packages/main/dist/ShellBar.js 541 B 0 B
packages/main/dist/ShellBarItem.js 375 B 0 B
packages/main/dist/SideNavigation.js 608 B 0 B
packages/main/dist/SideNavigationItem.js 413 B 0 B
packages/main/dist/SideNavigationSubItem.js 373 B 0 B
packages/main/dist/Size.js 151 B 0 B
packages/main/dist/Slider.js 493 B 0 B
packages/main/dist/StandardListItem.js 505 B 0 B
packages/main/dist/StepInput.js 602 B 0 B
packages/main/dist/SuggestionItem.js 432 B 0 B
packages/main/dist/Switch.js 597 B 0 B
packages/main/dist/Tab.js 472 B 0 B
packages/main/dist/TabContainer.js 524 B 0 B
packages/main/dist/TabContainerTabsPlacement.js 161 B 0 B
packages/main/dist/TabLayout.js 150 B 0 B
packages/main/dist/Table.js 660 B 0 B
packages/main/dist/TableCell.js 330 B 0 B
packages/main/dist/TableColumn.js 400 B 0 B
packages/main/dist/TableGrowingMode.js 165 B 0 B
packages/main/dist/TablePlaceholder.js 799 B 0 B
packages/main/dist/TableRow.js 313 B 0 B
packages/main/dist/TableScaleWidthMode.js 169 B 0 B
packages/main/dist/TableSelectionBehavior.js 178 B 0 B
packages/main/dist/TableSelectionMode.js 182 B 0 B
packages/main/dist/TableVisibleRowCountMode.js 189 B 0 B
packages/main/dist/TabSeparator.js 338 B 0 B
packages/main/dist/Text.js 986 B 0 B
packages/main/dist/TextAlign.js 183 B 0 B
packages/main/dist/TextArea.js 638 B 0 B
packages/main/dist/ThemeProvider.js 989 B 0 B
packages/main/dist/Themes.js 188 B 0 B
packages/main/dist/Timeline.js 568 B 0 B
packages/main/dist/TimelineItem.js 364 B 0 B
packages/main/dist/TimePicker.js 539 B 0 B
packages/main/dist/Title.js 399 B 0 B
packages/main/dist/TitleLevel.js 163 B 0 B
packages/main/dist/Toast.js 418 B 0 B
packages/main/dist/ToastPlacement.js 208 B 0 B
packages/main/dist/ToggleButton.js 653 B 0 B
packages/main/dist/Token.js 379 B 0 B
packages/main/dist/Toolbar.js 3.29 kB 0 B
packages/main/dist/ToolbarDesign.js 175 B 0 B
packages/main/dist/ToolbarSeparator.js 562 B 0 B
packages/main/dist/ToolbarSpacer.js 220 B 0 B
packages/main/dist/ToolbarStyle.js 153 B 0 B
packages/main/dist/Tree.js 416 B 0 B
packages/main/dist/TreeItem.js 451 B 0 B
packages/main/dist/UploadCollection.js 473 B 0 B
packages/main/dist/UploadCollectionItem.js 514 B 0 B
packages/main/dist/UploadState.js 170 B 0 B
packages/main/dist/ValueState.js 182 B 0 B
packages/main/dist/VariantManagement.js 2.03 kB 0 B
packages/main/dist/VerticalAlign.js 174 B 0 B
packages/main/dist/withWebComponent.js 1.7 kB 0 B
packages/main/dist/Wizard.js 424 B 0 B
packages/main/dist/WizardStep.js 441 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented May 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 831234563

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 79.135%
Totals Coverage Status
Change from base Build 830779006: 0.006%
Covered Lines: 2799
Relevant Lines: 3537
💛 - Coveralls

MarcusNotheis
MarcusNotheis requested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@MarcusNotheis MarcusNotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is possible to shorten the commit message? It feels very lengthy 😄

@Lukas742 Lukas742 changed the title fix(FilterBar): don't show toolbar separator if variants is not set, don't show overflow button if no buttons are displayed fix(FilterBar): only display toolbar separator & overflow button when necessary May 11, 2021
@Lukas742 @MarcusNotheis
Update packages/main/src/components/FilterBar/index.tsx
f839c7d 
Co-authored-by: Marcus Notheis <marcus.notheis@sap.com>
@Lukas742 Lukas742 requested a review from MarcusNotheis May 11, 2021 10:10
@MarcusNotheis MarcusNotheis merged commit 518d4c4 into main May 11, 2021
@MarcusNotheis MarcusNotheis deleted the fix/filter-bar-overflow-toolbar branch May 11, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcusNotheis MarcusNotheis MarcusNotheis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lukas742 @coveralls @MarcusNotheis