Skip to content

Conversation

@Lukas742
Copy link
Contributor

  • Add missing aria labels
  • Use unordered list to display items
  • Only focus first or previously focused item with tab
  • Allow right and left navigation between breadcrumbs with arrow keys

@coveralls
Copy link

coveralls commented Apr 13, 2021

Pull Request Test Coverage Report for Build 744799268

  • 6 of 13 (46.15%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 79.597%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/main/src/components/Breadcrumbs/index.tsx 6 13 46.15%
Totals Coverage Status
Change from base Build 744518255: -0.1%
Covered Lines: 2766
Relevant Lines: 3475

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Apr 13, 2021

Size Change: +811 B (0%)

Total Size: 191 kB

Filename Size Change
packages/main/dist/Breadcrumbs.js 1.61 kB +811 B (+102%) 🆘
ℹ️ View Unchanged
Filename Size Change
packages/base/dist/CssSizeVariables.js 958 B 0 B
packages/base/dist/Device.js 4.61 kB 0 B
packages/base/dist/hooks.js 1.69 kB 0 B
packages/base/dist/Logger.js 996 B 0 B
packages/base/dist/spacing.js 1 kB 0 B
packages/base/dist/StyleClassHelper.js 343 B 0 B
packages/base/dist/ThemingParameters.js 3.6 kB 0 B
packages/base/dist/useConsolidatedRef.js 265 B 0 B
packages/base/dist/usePassThroughHtmlProps.js 288 B 0 B
packages/base/dist/useViewportRange.js 425 B 0 B
packages/base/dist/Utils.js 740 B 0 B
packages/charts/dist/BarChart.js 3.95 kB 0 B
packages/charts/dist/BarChartPlaceholder.js 450 B 0 B
packages/charts/dist/ColumnChart.js 4.15 kB 0 B
packages/charts/dist/ColumnChartPlaceholder.js 506 B 0 B
packages/charts/dist/components/ChartContainer.js 1.25 kB 0 B
packages/charts/dist/components/ChartDataLabel.js 604 B 0 B
packages/charts/dist/components/ComposedChartPlaceholder.js 855 B 0 B
packages/charts/dist/components/XAxisTicks.js 613 B 0 B
packages/charts/dist/components/YAxisTicks.js 510 B 0 B
packages/charts/dist/ComposedChart.js 4.86 kB 0 B
packages/charts/dist/DonutChart.js 3.06 kB 0 B
packages/charts/dist/LineChart.js 4.03 kB 0 B
packages/charts/dist/LineChartPlaceholder.js 523 B 0 B
packages/charts/dist/MicroBarChart.js 2.02 kB 0 B
packages/charts/dist/PieChart.js 2.94 kB 0 B
packages/charts/dist/PieChartPlaceholder.js 440 B 0 B
packages/charts/dist/RadarChart.js 2.1 kB 0 B
packages/charts/dist/RadialChart.js 1.23 kB 0 B
packages/charts/dist/ScatterChart.js 3.76 kB 0 B
packages/charts/dist/ScatterChartPlaceholder.js 530 B 0 B
packages/charts/dist/useLegendItemClick.js 341 B 0 B
packages/charts/dist/Utils.js 389 B 0 B
packages/main/dist/ActionSheet.js 1.34 kB 0 B
packages/main/dist/AnalyticalCard.js 860 B 0 B
packages/main/dist/AnalyticalCardHeader.js 2.61 kB 0 B
packages/main/dist/AnalyticalTable.js 23.3 kB 0 B
packages/main/dist/AnalyticalTableHooks.js 1.64 kB 0 B
packages/main/dist/AnalyticalTableScrollMode.js 176 B 0 B
packages/main/dist/Assets-static.js 56 B 0 B
packages/main/dist/Assets.js 49 B 0 B
packages/main/dist/assets/i18n/i18n-defaults.js 863 B 0 B
packages/main/dist/Avatar.js 592 B 0 B
packages/main/dist/AvatarBackgroundColor.js 218 B 0 B
packages/main/dist/AvatarFitType.js 151 B 0 B
packages/main/dist/AvatarGroup.js 620 B 0 B
packages/main/dist/AvatarGroupType.js 155 B 0 B
packages/main/dist/AvatarShape.js 150 B 0 B
packages/main/dist/AvatarSize.js 155 B 0 B
packages/main/dist/Badge.js 449 B 0 B
packages/main/dist/Bar.js 432 B 0 B
packages/main/dist/BarDesign.js 169 B 0 B
packages/main/dist/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/dist/BusyIndicator.js 448 B 0 B
packages/main/dist/BusyIndicatorSize.js 166 B 0 B
packages/main/dist/Button.js 472 B 0 B
packages/main/dist/ButtonDesign.js 190 B 0 B
packages/main/dist/Calendar.js 661 B 0 B
packages/main/dist/CalendarDate.js 255 B 0 B
packages/main/dist/CalendarSelection.js 163 B 0 B
packages/main/dist/CalendarSelectionMode.js 166 B 0 B
packages/main/dist/CalendarType.js 212 B 0 B
packages/main/dist/Card.js 485 B 0 B
packages/main/dist/Carousel.js 542 B 0 B
packages/main/dist/CarouselArrowsPlacement.js 166 B 0 B
packages/main/dist/CheckBox.js 591 B 0 B
packages/main/dist/ColorPalette.js 379 B 0 B
packages/main/dist/ColorPaletteItem.js 345 B 0 B
packages/main/dist/ColorPicker.js 335 B 0 B
packages/main/dist/ComboBox.js 555 B 0 B
packages/main/dist/ComboBoxItem.js 333 B 0 B
packages/main/dist/ContentDensity.js 151 B 0 B
packages/main/dist/CustomListItem.js 449 B 0 B
packages/main/dist/DatePicker.js 593 B 0 B
packages/main/dist/DateRangePicker.js 546 B 0 B
packages/main/dist/DateTimePicker.js 568 B 0 B
packages/main/dist/DeviationIndicator.js 160 B 0 B
packages/main/dist/Dialog.js 715 B 0 B
packages/main/dist/DurationPicker.js 603 B 0 B
packages/main/dist/DynamicPage.js 4.32 kB 0 B
packages/main/dist/DynamicPageHeader.js 1.44 kB 0 B
packages/main/dist/DynamicPageTitle.js 1.62 kB 0 B
packages/main/dist/FCLLayout.js 236 B 0 B
packages/main/dist/FileUploader.js 683 B 0 B
packages/main/dist/FilterBar.js 7.05 kB 0 B
packages/main/dist/FilterGroupItem.js 1.27 kB 0 B
packages/main/dist/FlexBox.js 1.08 kB 0 B
packages/main/dist/FlexBoxAlignItems.js 188 B 0 B
packages/main/dist/FlexBoxDirection.js 169 B 0 B
packages/main/dist/FlexBoxJustifyContent.js 194 B 0 B
packages/main/dist/FlexBoxWrap.js 154 B 0 B
packages/main/dist/FlexibleColumnLayout.js 521 B 0 B
packages/main/dist/Form.js 2.72 kB 0 B
packages/main/dist/FormGroup.js 706 B 0 B
packages/main/dist/FormItem.js 1.2 kB 0 B
packages/main/dist/GlobalStyleClasses.js 151 B 0 B
packages/main/dist/Grid.js 2.03 kB 0 B
packages/main/dist/GridPosition.js 157 B 0 B
packages/main/dist/GroupHeaderListItem.js 370 B 0 B
packages/main/dist/Icon.js 655 B 0 B
packages/main/dist/Input.js 827 B 0 B
packages/main/dist/InputType.js 184 B 0 B
packages/main/dist/json-imports/i18n-static.js 1.06 kB 0 B
packages/main/dist/json-imports/i18n.js 963 B 0 B
packages/main/dist/Label.js 572 B 0 B
packages/main/dist/Link.js 519 B 0 B
packages/main/dist/LinkDesign.js 190 B 0 B
packages/main/dist/List.js 730 B 0 B
packages/main/dist/ListGrowingMode.js 164 B 0 B
packages/main/dist/ListItemTypes.js 160 B 0 B
packages/main/dist/ListMode.js 189 B 0 B
packages/main/dist/ListSeparators.js 186 B 0 B
packages/main/dist/Loader.js 1.45 kB 0 B
packages/main/dist/LoaderType.js 152 B 0 B
packages/main/dist/MessageBox.js 2.55 kB 0 B
packages/main/dist/MessageBoxActions.js 228 B 0 B
packages/main/dist/MessageBoxTypes.js 231 B 0 B
packages/main/dist/MessageStrip.js 511 B 0 B
packages/main/dist/MessageStripType.js 181 B 0 B
packages/main/dist/MultiComboBox.js 720 B 0 B
packages/main/dist/MultiComboBoxItem.js 365 B 0 B
packages/main/dist/MultiInput.js 716 B 0 B
packages/main/dist/NotificationAction.js 420 B 0 B
packages/main/dist/NotificationListGroupItem.js 596 B 0 B
packages/main/dist/NotificationListItem.js 654 B 0 B
packages/main/dist/ObjectPage.js 9.88 kB 0 B
packages/main/dist/ObjectPageMode.js 159 B 0 B
packages/main/dist/ObjectPageSection.js 1.17 kB 0 B
packages/main/dist/ObjectPageSubSection.js 1.06 kB 0 B
packages/main/dist/ObjectStatus.js 1.23 kB 0 B
packages/main/dist/Option.js 369 B 0 B
packages/main/dist/Page.js 477 B 0 B
packages/main/dist/PageBackgroundDesign.js 184 B 0 B
packages/main/dist/Panel.js 488 B 0 B
packages/main/dist/PanelAccessibleRoles.js 200 B 0 B
packages/main/dist/PlacementType.js 174 B 0 B
packages/main/dist/Popover.js 641 B 0 B
packages/main/dist/PopoverHorizontalAlign.js 180 B 0 B
packages/main/dist/PopoverPlacementType.js 171 B 0 B
packages/main/dist/PopoverVerticalAlign.js 203 B 0 B
packages/main/dist/Priority.js 163 B 0 B
packages/main/dist/ProductSwitch.js 375 B 0 B
packages/main/dist/ProductSwitchItem.js 423 B 0 B
packages/main/dist/ProgressIndicator.js 434 B 0 B
packages/main/dist/RadioButton.js 589 B 0 B
packages/main/dist/RangeSlider.js 503 B 0 B
packages/main/dist/RatingIndicator.js 439 B 0 B
packages/main/dist/ResponsivePopover.js 606 B 0 B
packages/main/dist/SegmentedButton.js 475 B 0 B
packages/main/dist/Select.js 433 B 0 B
packages/main/dist/SemanticColor.js 181 B 0 B
packages/main/dist/ShellBar.js 543 B 0 B
packages/main/dist/ShellBarItem.js 376 B 0 B
packages/main/dist/SideNavigation.js 608 B 0 B
packages/main/dist/SideNavigationItem.js 414 B 0 B
packages/main/dist/SideNavigationSubItem.js 373 B 0 B
packages/main/dist/Size.js 151 B 0 B
packages/main/dist/Slider.js 494 B 0 B
packages/main/dist/StandardListItem.js 506 B 0 B
packages/main/dist/StepInput.js 602 B 0 B
packages/main/dist/SuggestionItem.js 434 B 0 B
packages/main/dist/Switch.js 597 B 0 B
packages/main/dist/Tab.js 472 B 0 B
packages/main/dist/TabContainer.js 524 B 0 B
packages/main/dist/TabContainerTabsPlacement.js 160 B 0 B
packages/main/dist/TabLayout.js 150 B 0 B
packages/main/dist/Table.js 660 B 0 B
packages/main/dist/TableCell.js 332 B 0 B
packages/main/dist/TableColumn.js 400 B 0 B
packages/main/dist/TableGrowingMode.js 165 B 0 B
packages/main/dist/TablePlaceholder.js 781 B 0 B
packages/main/dist/TableRow.js 314 B 0 B
packages/main/dist/TableScaleWidthMode.js 169 B 0 B
packages/main/dist/TableSelectionBehavior.js 178 B 0 B
packages/main/dist/TableSelectionMode.js 182 B 0 B
packages/main/dist/TableVisibleRowCountMode.js 189 B 0 B
packages/main/dist/TabSeparator.js 339 B 0 B
packages/main/dist/Text.js 986 B 0 B
packages/main/dist/TextAlign.js 183 B 0 B
packages/main/dist/TextArea.js 639 B 0 B
packages/main/dist/ThemeProvider.js 981 B 0 B
packages/main/dist/Themes.js 188 B 0 B
packages/main/dist/Timeline.js 569 B 0 B
packages/main/dist/TimelineItem.js 364 B 0 B
packages/main/dist/TimePicker.js 539 B 0 B
packages/main/dist/Title.js 400 B 0 B
packages/main/dist/TitleLevel.js 163 B 0 B
packages/main/dist/Toast.js 419 B 0 B
packages/main/dist/ToastPlacement.js 207 B 0 B
packages/main/dist/ToggleButton.js 653 B 0 B
packages/main/dist/Token.js 378 B 0 B
packages/main/dist/Toolbar.js 3.3 kB 0 B
packages/main/dist/ToolbarDesign.js 175 B 0 B
packages/main/dist/ToolbarSeparator.js 557 B 0 B
packages/main/dist/ToolbarSpacer.js 216 B 0 B
packages/main/dist/ToolbarStyle.js 153 B 0 B
packages/main/dist/Tree.js 413 B 0 B
packages/main/dist/TreeItem.js 451 B 0 B
packages/main/dist/UploadCollection.js 475 B 0 B
packages/main/dist/UploadCollectionItem.js 515 B 0 B
packages/main/dist/UploadState.js 170 B 0 B
packages/main/dist/ValueState.js 182 B 0 B
packages/main/dist/VariantManagement.js 2.02 kB 0 B
packages/main/dist/VerticalAlign.js 173 B 0 B
packages/main/dist/withWebComponent.js 1.54 kB 0 B
packages/main/dist/Wizard.js 424 B 0 B
packages/main/dist/WizardStep.js 442 B 0 B

compressed-size-action

@MarcusNotheis MarcusNotheis enabled auto-merge (squash) April 13, 2021 13:00
@MarcusNotheis MarcusNotheis merged commit 65c3bbd into main Apr 13, 2021
@MarcusNotheis MarcusNotheis deleted the fix/breadcrumbs-a11y branch April 13, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breadcrumbs:[A11y Issue] Visually apparent "list" of links not made programmatic list in breadcrumb trail

4 participants