Skip to content

docs: improve docs for charts #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 21, 2021
Merged

docs: improve docs for charts #1198

merged 25 commits into from
Jan 21, 2021

Conversation

@MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Jan 21, 2021

No description provided.

@MarcusNotheis MarcusNotheis linked an issue Jan 21, 2021 that may be closed by this pull request
☂️ Improve Documentation #689
Closed
78 tasks
@github-actions
Copy link

github-actions bot commented Jan 21, 2021 •
edited
Loading

Size Change: +1.2 kB (+1%)

Total Size: 188 kB

Filename Size Change
packages/charts/lib/BarChart.js 4.05 kB +101 B (+3%)
packages/charts/lib/ColumnChart.js 4.27 kB +103 B (+2%)
packages/charts/lib/ComposedChart.js 4.98 kB +63 B (+1%)
packages/charts/lib/DonutChart.js 3.06 kB +256 B (+9%) 🔍
packages/charts/lib/LineChart.js 4.12 kB +57 B (+1%)
packages/charts/lib/MicroBarChart.js 2.02 kB +77 B (+4%)
packages/charts/lib/PieChart.js 2.94 kB +202 B (+7%) 🔍
packages/charts/lib/RadarChart.js 2.18 kB +91 B (+4%)
packages/charts/lib/RadialChart.js 1.24 kB +68 B (+6%) 🔍
packages/charts/lib/ScatterChart.js 3.89 kB +185 B (+5%) 🔍
ℹ️ View Unchanged
Filename Size Change
packages/base/lib/createComponentStyles.js 206 B 0 B
packages/base/lib/CssSizeVariables.js 918 B 0 B
packages/base/lib/Device.js 5.22 kB 0 B
packages/base/lib/hooks.js 2.53 kB 0 B
packages/base/lib/Logger.js 1.2 kB 0 B
packages/base/lib/spacing.js 999 B 0 B
packages/base/lib/StyleClassHelper.js 610 B 0 B
packages/base/lib/ThemingParameters.js 3.6 kB 0 B
packages/base/lib/useConsolidatedRef.js 271 B 0 B
packages/base/lib/usePassThroughHtmlProps.js 327 B 0 B
packages/base/lib/useViewportRange.js 431 B 0 B
packages/base/lib/Utils.js 647 B 0 B
packages/charts/lib/BarChartPlaceholder.js 456 B 0 B
packages/charts/lib/ColumnChartPlaceholder.js 514 B 0 B
packages/charts/lib/components/ChartContainer.js 1.42 kB 0 B
packages/charts/lib/components/ChartDataLabel.js 605 B 0 B
packages/charts/lib/components/ComposedChartPlaceholder.js 878 B 0 B
packages/charts/lib/components/XAxisTicks.js 616 B 0 B
packages/charts/lib/components/YAxisTicks.js 513 B 0 B
packages/charts/lib/LineChartPlaceholder.js 529 B 0 B
packages/charts/lib/PieChartPlaceholder.js 445 B 0 B
packages/charts/lib/ScatterChartPlaceholder.js 535 B 0 B
packages/charts/lib/useLegendItemClick.js 391 B 0 B
packages/charts/lib/Utils.js 534 B 0 B
packages/main/lib/ActionSheet.js 1.36 kB 0 B
packages/main/lib/AnalyticalCard.js 852 B 0 B
packages/main/lib/AnalyticalCardHeader.js 2.61 kB 0 B
packages/main/lib/AnalyticalTable.js 22.9 kB 0 B
packages/main/lib/AnalyticalTableHooks.js 1.73 kB 0 B
packages/main/lib/AnalyticalTableScrollMode.js 177 B 0 B
packages/main/lib/Avatar.js 589 B 0 B
packages/main/lib/AvatarBackgroundColor.js 219 B 0 B
packages/main/lib/AvatarFitType.js 151 B 0 B
packages/main/lib/AvatarGroup.js 601 B 0 B
packages/main/lib/AvatarGroupType.js 155 B 0 B
packages/main/lib/AvatarShape.js 150 B 0 B
packages/main/lib/AvatarSize.js 155 B 0 B
packages/main/lib/Badge.js 445 B 0 B
packages/main/lib/Bar.js 430 B 0 B
packages/main/lib/BarDesign.js 169 B 0 B
packages/main/lib/Breadcrumbs.js 795 B 0 B
packages/main/lib/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/lib/BusyIndicator.js 444 B 0 B
packages/main/lib/BusyIndicatorSize.js 167 B 0 B
packages/main/lib/Button.js 469 B 0 B
packages/main/lib/ButtonDesign.js 190 B 0 B
packages/main/lib/Calendar.js 463 B 0 B
packages/main/lib/CalendarSelection.js 163 B 0 B
packages/main/lib/CalendarType.js 212 B 0 B
packages/main/lib/Card.js 480 B 0 B
packages/main/lib/Carousel.js 538 B 0 B
packages/main/lib/CarouselArrowsPlacement.js 166 B 0 B
packages/main/lib/CheckBox.js 586 B 0 B
packages/main/lib/ComboBox.js 543 B 0 B
packages/main/lib/ComboBoxItem.js 327 B 0 B
packages/main/lib/ContentDensity.js 151 B 0 B
packages/main/lib/CustomListItem.js 446 B 0 B
packages/main/lib/DatePicker.js 612 B 0 B
packages/main/lib/DateRangePicker.js 573 B 0 B
packages/main/lib/DateTimePicker.js 586 B 0 B
packages/main/lib/DeviationIndicator.js 160 B 0 B
packages/main/lib/Dialog.js 711 B 0 B
packages/main/lib/DurationPicker.js 549 B 0 B
packages/main/lib/DynamicPage.js 4.2 kB 0 B
packages/main/lib/DynamicPageHeader.js 1.34 kB 0 B
packages/main/lib/DynamicPageTitle.js 1.5 kB 0 B
packages/main/lib/FCLLayout.js 236 B 0 B
packages/main/lib/FileUploader.js 680 B 0 B
packages/main/lib/FilterBar.js 7.1 kB 0 B
packages/main/lib/FilterGroupItem.js 1.27 kB 0 B
packages/main/lib/FlexBox.js 1.08 kB 0 B
packages/main/lib/FlexBoxAlignItems.js 189 B 0 B
packages/main/lib/FlexBoxDirection.js 169 B 0 B
packages/main/lib/FlexBoxJustifyContent.js 194 B 0 B
packages/main/lib/FlexBoxWrap.js 154 B 0 B
packages/main/lib/FlexibleColumnLayout.js 517 B 0 B
packages/main/lib/Form.js 2.67 kB 0 B
packages/main/lib/FormGroup.js 547 B 0 B
packages/main/lib/FormItem.js 1.17 kB 0 B
packages/main/lib/GlobalStyleClasses.js 151 B 0 B
packages/main/lib/Grid.js 1.61 kB 0 B
packages/main/lib/GridPosition.js 157 B 0 B
packages/main/lib/GroupHeaderListItem.js 368 B 0 B
packages/main/lib/Icon.js 651 B 0 B
packages/main/lib/Input.js 830 B 0 B
packages/main/lib/InputType.js 184 B 0 B
packages/main/lib/Label.js 567 B 0 B
packages/main/lib/Link.js 519 B 0 B
packages/main/lib/LinkDesign.js 191 B 0 B
packages/main/lib/List.js 717 B 0 B
packages/main/lib/ListItemTypes.js 160 B 0 B
packages/main/lib/ListMode.js 191 B 0 B
packages/main/lib/ListSeparators.js 186 B 0 B
packages/main/lib/Loader.js 1.46 kB 0 B
packages/main/lib/LoaderType.js 152 B 0 B
packages/main/lib/MessageBox.js 2.57 kB 0 B
packages/main/lib/MessageBoxActions.js 231 B 0 B
packages/main/lib/MessageBoxTypes.js 232 B 0 B
packages/main/lib/MessageStrip.js 508 B 0 B
packages/main/lib/MessageStripType.js 181 B 0 B
packages/main/lib/MultiComboBox.js 716 B 0 B
packages/main/lib/MultiComboBoxItem.js 360 B 0 B
packages/main/lib/MultiInput.js 718 B 0 B
packages/main/lib/NotificationAction.js 415 B 0 B
packages/main/lib/NotificationListGroupItem.js 585 B 0 B
packages/main/lib/NotificationListItem.js 651 B 0 B
packages/main/lib/ObjectPage.js 9.44 kB 0 B
packages/main/lib/ObjectPageMode.js 159 B 0 B
packages/main/lib/ObjectPageSection.js 1.29 kB 0 B
packages/main/lib/ObjectPageSubSection.js 1.19 kB 0 B
packages/main/lib/ObjectStatus.js 1.24 kB 0 B
packages/main/lib/Option.js 343 B 0 B
packages/main/lib/Page.js 2.41 kB 0 B
packages/main/lib/PageBackgroundDesign.js 183 B 0 B
packages/main/lib/Panel.js 474 B 0 B
packages/main/lib/PanelAccessibleRoles.js 201 B 0 B
packages/main/lib/PlacementType.js 175 B 0 B
packages/main/lib/Popover.js 637 B 0 B
packages/main/lib/PopoverHorizontalAlign.js 181 B 0 B
packages/main/lib/PopoverPlacementType.js 172 B 0 B
packages/main/lib/PopoverVerticalAlign.js 204 B 0 B
packages/main/lib/Priority.js 163 B 0 B
packages/main/lib/ProductSwitch.js 372 B 0 B
packages/main/lib/ProductSwitchItem.js 418 B 0 B
packages/main/lib/ProgressIndicator.js 426 B 0 B
packages/main/lib/RadioButton.js 585 B 0 B
packages/main/lib/RangeSlider.js 499 B 0 B
packages/main/lib/RatingIndicator.js 434 B 0 B
packages/main/lib/ResponsivePopover.js 601 B 0 B
packages/main/lib/SegmentedButton.js 471 B 0 B
packages/main/lib/Select.js 430 B 0 B
packages/main/lib/SemanticColor.js 181 B 0 B
packages/main/lib/ShellBar.js 537 B 0 B
packages/main/lib/ShellBarItem.js 371 B 0 B
packages/main/lib/SideNavigation.js 605 B 0 B
packages/main/lib/SideNavigationItem.js 410 B 0 B
packages/main/lib/SideNavigationSubItem.js 368 B 0 B
packages/main/lib/Size.js 151 B 0 B
packages/main/lib/Slider.js 489 B 0 B
packages/main/lib/StandardListItem.js 503 B 0 B
packages/main/lib/SuggestionItem.js 430 B 0 B
packages/main/lib/Switch.js 592 B 0 B
packages/main/lib/Tab.js 469 B 0 B
packages/main/lib/TabContainer.js 520 B 0 B
packages/main/lib/TabContainerTabsPlacement.js 161 B 0 B
packages/main/lib/TabLayout.js 150 B 0 B
packages/main/lib/Table.js 627 B 0 B
packages/main/lib/TableCell.js 326 B 0 B
packages/main/lib/TableColumn.js 395 B 0 B
packages/main/lib/TablePlaceholder.js 799 B 0 B
packages/main/lib/TableRow.js 309 B 0 B
packages/main/lib/TableScaleWidthMode.js 169 B 0 B
packages/main/lib/TableSelectionBehavior.js 178 B 0 B
packages/main/lib/TableSelectionMode.js 182 B 0 B
packages/main/lib/TableVisibleRowCountMode.js 189 B 0 B
packages/main/lib/TabSeparator.js 334 B 0 B
packages/main/lib/Text.js 987 B 0 B
packages/main/lib/TextAlign.js 183 B 0 B
packages/main/lib/TextArea.js 634 B 0 B
packages/main/lib/ThemeProvider.js 1.19 kB 0 B
packages/main/lib/Themes.js 188 B 0 B
packages/main/lib/Timeline.js 565 B 0 B
packages/main/lib/TimelineItem.js 361 B 0 B
packages/main/lib/TimePicker.js 535 B 0 B
packages/main/lib/Title.js 397 B 0 B
packages/main/lib/TitleLevel.js 163 B 0 B
packages/main/lib/Toast.js 416 B 0 B
packages/main/lib/ToastPlacement.js 208 B 0 B
packages/main/lib/ToggleButton.js 650 B 0 B
packages/main/lib/Token.js 375 B 0 B
packages/main/lib/Toolbar.js 3.29 kB 0 B
packages/main/lib/ToolbarDesign.js 175 B 0 B
packages/main/lib/ToolbarSeparator.js 477 B 0 B
packages/main/lib/ToolbarSpacer.js 220 B 0 B
packages/main/lib/ToolbarStyle.js 153 B 0 B
packages/main/lib/Tree.js 412 B 0 B
packages/main/lib/TreeItem.js 412 B 0 B
packages/main/lib/UploadCollection.js 470 B 0 B
packages/main/lib/UploadCollectionItem.js 461 B 0 B
packages/main/lib/UploadState.js 170 B 0 B
packages/main/lib/ValueState.js 182 B 0 B
packages/main/lib/VariantManagement.js 2.04 kB 0 B
packages/main/lib/VerticalAlign.js 174 B 0 B
packages/main/lib/withWebComponent.js 1.61 kB 0 B
packages/main/lib/Wizard.js 419 B 0 B
packages/main/lib/WizardStep.js 436 B 0 B

compressed-size-action

@Lukas742
add default props and descriptions
1404ba2
@Lukas742
Merge branch 'docs/charts' of github.com:SAP/ui5-webcomponents-react …
bacecf4 
…into docs/charts

# Conflicts:
#	packages/charts/src/components/BarChart/BarChart.tsx
#	packages/charts/src/components/ColumnChart/ColumnChart.tsx
#	packages/charts/src/components/ComposedChart/index.tsx
#	packages/charts/src/components/DonutChart/DonutChart.stories.mdx
#	packages/charts/src/components/LineChart/LineChart.tsx
#	packages/charts/src/components/MicroBarChart/MicroBarChart.tsx
#	packages/charts/src/components/PieChart/PieChart.stories.mdx
#	packages/charts/src/components/PieChart/PieChart.tsx
#	packages/charts/src/components/RadarChart/RadarChart.tsx
#	packages/charts/src/components/RadialChart/RadialChart.stories.mdx
#	packages/charts/src/components/RadialChart/RadialChart.tsx
@Lukas742
replace h4 tags with md syntax
ee6c010
@MarcusNotheis MarcusNotheis merged commit 57b00ec into main Jan 21, 2021
@MarcusNotheis MarcusNotheis deleted the docs/charts branch January 21, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@kleinju1017 kleinju1017 Awaiting requested review from kleinju1017

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

☂️ Improve Documentation

3 participants

@MarcusNotheis @Lukas742