feat(project): Add component type #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
RandomByte
changed the title
RFC: #1083 JIRA: CPOUI5FOUNDATION-1106
RandomByte
force-pushed
the
feat/component-type
branch
from
a679e16 to
cf45bf4
Compare
Member
Author
|
@KlattG kindly review the single documentation page change at https://github.com/UI5/cli/pull/1182/files#diff-7002de83aad5e946847dc7d9edbe366bb54db39197032ba722cd0268ae4dcb99 |
KlattG
requested changes
Nov 11, 2025
Contributor
KlattG
left a comment
KlattG
left a comment
There was a problem hiding this comment.
Rephrased for lucidity and user-centricity.
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
d3xter666
reviewed
Nov 12, 2025
codeworrior
previously requested changes
Nov 12, 2025
…and manifest.json type
matz3
reviewed
Nov 12, 2025
matz3
reviewed
Nov 12, 2025
packages/project/lib/validation/schema/specVersion/kind/project.json
Outdated
Show resolved
Hide resolved
Member
Author
KlattG
previously requested changes
Nov 14, 2025
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
matz3
approved these changes
Nov 17, 2025
| } | ||
| }); | ||
|
|
||
| // Support rules should not be minified to have readable code in the Support Assistant |
Member
There was a problem hiding this comment.
Support rules are AFAIK a concept for libraries, so I wonder why we also do this for applications. But as we do, I think we should also do it here to stay consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: #1083
JIRA: CPOUI5FOUNDATION-1106