-
Notifications
You must be signed in to change notification settings - Fork 75
ci(release-please): Release please single PR #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please find a sample result of this flow in here: https://github.com/d3xter666/ui5-tooling/pull/139 Note: Please ignore the title, it has been updated later in the config |
|
Please see my comment here: https://github.com/d3xter666/ui5-tooling/pull/139#issuecomment-3473211965 |
|
For the shrinkwrap tool, I was wondering how we best integrate it in the monorepo. Maybe similar to the documentation as a dedicated package? Not sure whether |
matz3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My points have been addressed, but the comment by @RandomByte might still be open?
I don't have strong oppinion on how to handle this one. Here's the reasoning why it felt to me the right way to go:
I'm curious to hear your oppinion on that. |
|
My understanding is that the shrinkwrap tool does not have a "dependency" to Personally, I find it unconventional to put a helper tool into the root I would vote for putting it into a package similar to documentation. |
2aad48b to
56ce376
Compare
2 similar comments
1 similar comment
Now, the |
4a6092e to
ba0fdcf
Compare
8114115 to
37a6bd7
Compare
matz3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
.github/workflows/release-please.yml
Outdated
| # CLI is handled separately to update shrinkwrap | ||
| # Order of packages in the matrix does matter and is important! | ||
| # release-please updates the package.json dependencies with ones that do not exist yet on NPM | ||
| # Publish in the correct order is important, so that dependencies are available and resolved properly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and this line are basically saying the same, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworded it. Thanks!
RandomByte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JIRA: CPOUI5FOUNDATION-1142
JIRA: CPOUI5FOUNDATION-1164
This change modifies several things, so the whole workflow can be complete:
npm-shrinkwrap.jsonfor the CLI package before being released (out of monorepo's rootpackage-lock.json)shrinkwrap-extractorto deal with@ui5/cli'snpm-shrinkwrap.jsongeneration in a monorepository environmentdeploy-vitepress-docs.yamlso that it will generate API documentation out of published NPM packages and not from the packages within the monorepopackage.jsonscripts, so that they can be easily (re)used within the monorepo structure.