Skip to content

Conversation

cbergmann
Copy link

We had a requirement to use a diffent matchingRule for the Access Rule. This inported well but on the next run it did fail because it could not parse it. This fixes this

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

smortex and others added 30 commits June 21, 2024 17:38
https://www.openldap.org/doc/admin26/guide.html#ppolicy%20overlay
In upgrading openldap 2.5->2.6, you have to make ppolicy adjustments.
It's documented in "assumes ldap expert-ese", but from in an older bug:
https://bugs.openldap.org/show_bug.cgi?id=9666#c1

* You add (config-overlay) olcPPolicyCheckModule=somemodule.so
* You add (policies) pwdUseCheckModule=TRUE
* You remove (policies) pwdCheckModule=somemodule.so

... and puppet doesn't know about PPolicyCheckModule.  So here we are.
It's lumped in with a lot of other attributes, but it has siblings from
https://www.openldap.org/software/man.cgi?query=slapo-ppolicy&manpath=OpenLDAP+2.6-Release
Add `PPolicyCheckModule` as a valid database/overlay option
Allow Sensitive[String[1]] for rootpw
https://www.openldap.org/software/man.cgi?query=slapd-config&manpath=OpenLDAP+2.6-Release#GENERAL_DATABASE_OPTIONS
openldap2.6 introduces olcLastBind and olcLastBindPrecision options as a replacement for the older contrib-overlay slapo-lastbind(5)
Add LastBind and LastBindPrecision to database options
Replace systemd::dropin_file with systemd::manage_dropin
Currently only rootpw can be assigned as Sensitive, but in some cases one might want to keep the username (DN) out of the PuppetDB and the logs.

In our case, we use a secret lookup function that automatically wraps the data into a Sensitive type, and we store the DN and password together.
…sitive

Also allow to have Sensitive[String[1]] for rootdn
cbergmann and others added 12 commits May 13, 2025 13:02
We had a requirement to use a diffent matchingRule for the Access Rule. This inported well but on the next run it did fail because it could not parse it.
This fixes this
Allow matchingRule and attrstyle in olcAccess
Flushes happen every time a resource changes, whether it is creation,
destroy or modify. Ensure we do not needlesly copy-paste the ldapmodify
code in those three separate instances.

This also ensures that if a new property is ever added, we do not need
create a separate setter.

This commit thus also fixes a bug where if a `what` of an
openldap_access resource changed, it would not trigger an update.
The setter for that property was lost in the refactor of commit
91e9723. -> Fixes voxpupuli#420.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.