Skip to content

Conversation

@vegaluisjose
Copy link
Contributor

This improves rom verilog output by emitting the "always block" if and only if there are writes. For example, the following:

// Memory mem_0: tmp4
always @(posedge clk)
begin
end
assign tmp29 = mem_0[tmp28];
assign tmp30 = mem_0[tmp27];

is now emitted as:

// Memory mem_0: tmp4
assign tmp29 = mem_0[tmp28];
assign tmp30 = mem_0[tmp27];

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #399 (e3cbf0c) into development (0e6fdae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #399   +/-   ##
============================================
  Coverage        90.71%   90.71%           
============================================
  Files               24       24           
  Lines             5988     5990    +2     
============================================
+ Hits              5432     5434    +2     
  Misses             556      556           
Impacted Files Coverage Δ
pyrtl/importexport.py 85.67% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6fdae...e3cbf0c. Read the comment docs.

@mdko mdko merged commit 40f1863 into UCSBarchlab:development Aug 4, 2021
@mdko
Copy link
Contributor

mdko commented Aug 4, 2021

Looks good, thank you!

@mdko
Copy link
Contributor

mdko commented Aug 4, 2021

FYI I merged your PR, and also just noticed a few more improvements that could be made (and merged them in #400). Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants