Review hyperparameter tunning #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdelhafizm
reviewed
Feb 10, 2025
Collaborator
There was a problem hiding this comment.
I think I used K4 = 1-K3 instead of K3 = 1-K4. Not a huge deal, but if you want it to be consistent.
It would make sense to do a grid search over the whole space instead of just 0.5-0.9. I used [0, 0.2, 0.4, 0.6, 0.8, 1] for my experiments.
Collaborator
There was a problem hiding this comment.
Looks ok. I didn't work with these parameters too much so I don't know what a good search range is.
Member
Author
|
Closing as changes were implemented directly in develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mohamed please review these 3 files