RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes;#12
Open
RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes;#12
Conversation
… Need heavy modifications though
…defined module for Gymnasium env wrapping. Also have a zip with a trained model. Camera needs some work now.
aaronrhim
reviewed
Jan 29, 2026
aaronrhim
reviewed
Jan 29, 2026
added 2 commits
February 5, 2026 21:36
…ging Docker branch's version of this file. Also added sac_train and corresponding trained model! Also updated just sac_train so that it saves every few commits, changed robot, adds more logging methods, checkpoints
Cameron-Basara
requested changes
Feb 6, 2026
Contributor
Cameron-Basara
left a comment
There was a problem hiding this comment.
Few things, I don't have time to take a deep dive right now (Im sorry autonav is kicking my ass), I won't approve this right now:
- Can you please put together a demo notebook on your changes here? It doesn't have to be very fancy, just a small markdown description of:
- Your feature (Class or function or whatever)
- What it solves
Then a code block with a little demo of the feature doing its requirements.
If you want you can put a little side by side comp, if its an improvement on an existing feature. Dont have to. This will also help you sort out your thoughts and make sure everything is working! For each feature.. ;) - Please don't include your .claude settings, you'll have to remove it from the tracked files and append it to the gitignore
Nice work though :) Looks like your grinding! Remember the important part is to learn, so try not to vibe code too much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RL Base Classes
PPO SB3 base classes; non-camera based, loading and saving integrated which is why there's a zip file included (just a test, can delete for better integration)
Camera model not done; need to figure out how to define camera angle. Also made this a modular structure like a package.