Skip to content

RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes;#12

Open
Luxaris wants to merge 15 commits intomainfrom
prnv/rl-base-classes
Open

RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes;#12
Luxaris wants to merge 15 commits intomainfrom
prnv/rl-base-classes

Conversation

@Luxaris
Copy link

@Luxaris Luxaris commented Jan 26, 2026

RL Base Classes

PPO SB3 base classes; non-camera based, loading and saving integrated which is why there's a zip file included (just a test, can delete for better integration)

Camera model not done; need to figure out how to define camera angle. Also made this a modular structure like a package.

@Luxaris Luxaris self-assigned this Jan 26, 2026
@Luxaris Luxaris changed the title RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes RL Base Classes - PPO SB3 based classes; non-camera, loading and saving model for our parent classes; Feb 4, 2026
Pranav Rajesh Krishnan added 2 commits February 5, 2026 21:36
…ging Docker branch's version of this file. Also added sac_train and corresponding trained model! Also updated just sac_train so that it saves every few commits, changed robot, adds more logging methods, checkpoints
Copy link
Contributor

@Cameron-Basara Cameron-Basara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things, I don't have time to take a deep dive right now (Im sorry autonav is kicking my ass), I won't approve this right now:

  • Can you please put together a demo notebook on your changes here? It doesn't have to be very fancy, just a small markdown description of:
    - Your feature (Class or function or whatever)
    - What it solves
    Then a code block with a little demo of the feature doing its requirements.
    If you want you can put a little side by side comp, if its an improvement on an existing feature. Dont have to. This will also help you sort out your thoughts and make sure everything is working! For each feature.. ;)
  • Please don't include your .claude settings, you'll have to remove it from the tracked files and append it to the gitignore

Nice work though :) Looks like your grinding! Remember the important part is to learn, so try not to vibe code too much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants