Repository navigation
Fix UWP compatibility after System.Text.Json update - #971
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #967
Issue #967 reports that v6.6.1 and v6.6.2 fail the UWP .NET Native Toolchain with "Sequence contains more than one element", while v6.6.0 works. The dependency group update reintroduced System.Text.Json 10.x for netstandard2.0 consumers. This pins System.Text.Json to 9.0.2, the version used by the previously accepted UWP fix. JsonExtensions is pinned to 1.2.0 because its netstandard2.0 dependency in 1.2.3 requires System.Text.Json 10.0.8 or newer; the older package remains compatible with the 9.0.2 baseline. CS8002 is scoped to netstandard2.0 packaging because the internalized legacy package is unsigned.
Tests:
dotnet build YoutubeExplode/YoutubeExplode.csproj -c Release -f netstandard2.0 --no-restore— passed with 0 warnings and 0 errors.dotnet test YoutubeExplode.Tests/YoutubeExplode.Tests.csproj -c Release -f net48 --no-restore --filter FullyQualifiedName~LegacyTargetFrameworkSpecs— passed: 1 test.Limitations:
AI assistance: OpenAI Codex (GPT-5.6 Luna).