Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 27, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 27, 2025 16:18
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 27, 2025
Copilot finished reviewing on behalf of Tyrrrz November 27, 2025 16:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfill implementations for the Regex.Count(...) methods introduced in .NET 7.0, enabling their use in earlier .NET versions.

Key Changes:

  • Implements four Regex.Count(...) overloads: one instance method and three static methods with varying parameters
  • Adds comprehensive test coverage for all overloads
  • Updates documentation with the new API signatures

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
PolyShim/Signatures.md Updates totals to reflect 4 new member signatures and documents the new Regex.Count overloads
PolyShim/Net70/Regex.cs Implements polyfills for instance and static Count methods using Match/NextMatch loop and Regex.Matches(...).Count
PolyShim.Tests/Net70/RegexTests.cs Adds test coverage for all Count overloads including instance, static, with options, and with timeout variants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 905740c into master Nov 27, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the regex-count branch November 27, 2025 16:22
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (23ded1f) to head (4494c82).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #54   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants