Add polyfills for AppContext.TargetFrameworkName and TargetFrameworkAttribute
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
changed the title
AppContext.TargetFrameworkName and TargetFrameworkAttributeAppContext.TargetFrameworkName and TargetFrameworkAttribute
Copilot finished reviewing on behalf of
Tyrrrz
November 16, 2025 15:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds polyfills for AppContext.TargetFrameworkName and TargetFrameworkAttribute to enable their use on older .NET Framework versions that lack these APIs natively. The implementation follows the project's extension pattern to add the TargetFrameworkName property to AppContext on frameworks where it doesn't exist.
Key changes:
- Implements
TargetFrameworkAttributeclass for .NET Framework versions prior to 4.0 - Adds
AppContext.TargetFrameworkNameproperty polyfill using the extension pattern for older .NET Framework and .NET Standard versions - Includes test coverage to verify the polyfill functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PolyShim/NetCore10/TargetFrameworkAttribute.cs | Adds polyfill for TargetFrameworkAttribute with conditional compilation for pre-.NET 4.0 frameworks |
| PolyShim/NetCore10/AppContext.cs | Adds AppContext.TargetFrameworkName property polyfill with fallback type declaration for frameworks lacking AppContext |
| PolyShim.Tests/NetCore10/AppContextTests.cs | Adds test to verify AppContext.TargetFrameworkName returns the expected framework name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.