Skip to content

Add strong naming#67

Merged
Tyrrrz merged 1 commit into
Tyrrrz:primefrom
mgravell:marc/strong-name
Mar 25, 2026
Merged

Add strong naming#67
Tyrrrz merged 1 commit into
Tyrrrz:primefrom
mgravell:marc/strong-name

Conversation

@mgravell
Copy link
Copy Markdown
Contributor

Closes #66

  • create new snk for the project (sn -k)
  • (global build) specify the snk
  • (main assembly build) enable strong-name-signing

Main tests are green in Rider; secondary tests have some failure with/without the changes 🤷

- create new snk for the project (`sn -k`)
- (global build) specify the snk
- (main assembly build) enable strong-name-signing
@Tyrrrz Tyrrrz added the enhancement New feature or request label Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Propose strong-naming of the main dll Add strong-naming Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Add strong-naming Add strong naming Mar 25, 2026
@Tyrrrz
Copy link
Copy Markdown
Owner

Tyrrrz commented Mar 25, 2026

Thanks!

secondary tests have some failure with/without the changes 🤷

Those are demo tests that are meant to fail. They are excluded from dotnet test, but Rider runs them anyway by default.

@Tyrrrz Tyrrrz merged commit 3da2169 into Tyrrrz:prime Mar 25, 2026
7 checks passed
@mgravell
Copy link
Copy Markdown
Contributor Author

mgravell commented Mar 25, 2026

fix verified as successful (here), cheers

@mgravell mgravell deleted the marc/strong-name branch March 25, 2026 11:56
This was referenced Mar 25, 2026
github-actions Bot pushed a commit to saan800/github that referenced this pull request May 12, 2026
…#255)

Updated
[GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger)
from 3.0.0 to 3.0.4.

<details>
<summary>Release notes</summary>

_Sourced from [GitHubActionsTestLogger's
releases](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)._

## 3.0.4

<!-- Release notes generated using configuration in .github/release.yml
at 3.0.4 -->

## What's Changed
### Enhancements
* Add PowerKit (prerelease), update PolyShim and CSharpier, remove
duplicate utilities by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#72
### Bugs
* Explicitly dispose `summaryWriter` before reading file in truncation
tests by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#76
* Fix GITHUB_STEP_SUMMARY size limit exceeded with non-ASCII characters
by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#75


**Full Changelog**:
Tyrrrz/GitHubActionsTestLogger@3.0.3...3.0.4

## 3.0.3

## What's Changed
* Truncate or omit step summary when approaching GitHub's 1 MiB limit by
@​Copilot in Tyrrrz/GitHubActionsTestLogger#68
* Pin Microsoft.Testing.Platform reference to 2.0.0 by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#70


**Full Changelog**:
Tyrrrz/GitHubActionsTestLogger@3.0.2...3.0.3

## 3.0.2

## What's Changed
* Bump the nuget group with 4 updates by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#59
* Bump the nuget group with 1 update by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#60
* Migrate to Centralized NuGet Package Management (CPM) by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#61
* Use range indexer in `SubstringAfterLast` by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#62
* Bump the nuget group with 7 updates by @​dependabot[bot] in
Tyrrrz/GitHubActionsTestLogger#63
* Fix build errors from obsolete MTP API usage by @​Copilot in
Tyrrrz/GitHubActionsTestLogger#64
* Remove explicit Microsoft.SourceLink.GitHub package reference by
@​Copilot in Tyrrrz/GitHubActionsTestLogger#65
* Add strong naming by @​mgravell in
Tyrrrz/GitHubActionsTestLogger#67

## New Contributors
* @​Copilot made their first contribution in
Tyrrrz/GitHubActionsTestLogger#61
* @​mgravell made their first contribution in
Tyrrrz/GitHubActionsTestLogger#67

**Full Changelog**:
Tyrrrz/GitHubActionsTestLogger@3.0.1...3.0.2

## 3.0.1

**Full Changelog**:
Tyrrrz/GitHubActionsTestLogger@3.0...3.0.1

Commits viewable in [compare
view](Tyrrrz/GitHubActionsTestLogger@3.0...3.0.4).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing dev-dependency flag breaks usage with strong-named packages

2 participants