Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for env Terminal Option #33

Merged
merged 3 commits into from
Jan 1, 2019
Merged

Adding Support for env Terminal Option #33

merged 3 commits into from
Jan 1, 2019

Conversation

dhkatz
Copy link

@dhkatz dhkatz commented Dec 31, 2018

This adds support for the env option that exists in the TerminalOptions interface. This allows users to add more complex custom terminals such as MSYS2 that require certain environment variables to be set in order to properly open in the correct working directory.

This is a common use case for this option, often used to integrate MSYS2 terminal with VSCode:

    "shellLauncher.shells.windows": [
        {
            "shell": "C:\\msys64\\usr\\bin\\bash.exe",
            "label": "MSYS2",
            "args": ["--login", "-i"],
            "env": {
                "MSYSTEM": "MINGW64",
                "CHERE_INVOKING": "1"
            }
        }
    ]

@dhkatz
Copy link
Author

dhkatz commented Dec 31, 2018

In the event the author of this extension does not merge this pull request, I've added a release to my fork which you can manually install.

Install the .vsix file manually, easy to search if you do not know how.

https://github.com/DoctorJew/vscode-shell-launcher/releases/tag/v0.3.0

Copy link
Owner

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 😃

@Tyriar Tyriar merged commit d62fcfb into Tyriar:master Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants