Skip to content

Conversation

tom-ridsdale
Copy link

@tom-ridsdale tom-ridsdale commented Oct 17, 2025

Summary

https://typeform.atlassian.net/browse/TU-18127

Separate sandbox mode behaviour from submission-disabled mode by introducing a distinct enable-sandbox query parameter.

Problem

Previously, enableSandbox: true in the embed SDK would pass __dangerous-disable-submissions=true to the renderer, causing sandbox mode and submission-disabled mode to be treated identically. This prevents redirects from working in sandboxed embeds.

Solution

Pass enable-sandbox=true instead of __dangerous-disable-submissions=true when enableSandbox is set, allowing the renderer to distinguish between the two flows.

@tf-security
Copy link
Contributor

tf-security commented Oct 17, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash d60f07879a50b693607024fa2e5ebd4358433489 here.

Copy link

@tom-ridsdale tom-ridsdale marked this pull request as ready for review October 20, 2025 15:42
@tom-ridsdale tom-ridsdale requested a review from a team as a code owner October 20, 2025 15:42
Copy link

gitstream-cm bot commented Oct 20, 2025

🥷 Code experts: No results found

No code experts were identified for the files in this pull request based on git blame analysis.

This may occur when:

  • Files are new or have limited commit history
  • Git authors aren't mapped to current team members
  • Analysis thresholds need adjustment

If you expected to see expert suggestions, consider:

  • Reviewing your config.user_mapping settings

  • Adjusting the gt/lt parameters in your action

  • Verifying files have sufficient commit history

To learn more about /:\gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants