Skip to content

Better cleanup temporal files #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Chemaclass merged 5 commits into from
Oct 4, 2024
Merged

Better cleanup temporal files #349

Chemaclass merged 5 commits into from
Oct 4, 2024

Conversation

@Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Oct 3, 2024 •
edited
Loading

🔖 Changes

  • Improved temp_file and temp_dir
  • Call cleanup_temp_files at the end of bashunit > main::exec()
  • Use temp_file instead of mktemp for better cleanup

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix

@Chemaclass Chemaclass added the enhancement New feature or request label Oct 3, 2024
@Chemaclass Chemaclass self-assigned this Oct 3, 2024
@Chemaclass Chemaclass changed the title Better cleanup temp Better cleanup temporal files Oct 3, 2024
@Chemaclass Chemaclass added refactoring Refactoring or cleaning related and removed enhancement New feature or request labels Oct 3, 2024
@Chemaclass Chemaclass merged commit c7212e7 into main Oct 4, 2024
@Chemaclass Chemaclass deleted the refactor/better-cleanup-temp branch October 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesusValeraDev JesusValeraDev JesusValeraDev approved these changes

+1 more reviewer

@CosmeValera CosmeValera CosmeValera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Chemaclass Chemaclass

Labels

refactoring Refactoring or cleaning related

Projects

bashunit
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chemaclass @JesusValeraDev @CosmeValera