fix(runner): run teardown after setup failure - #1319
Merged
Conversation
File-scoped setup can acquire resources before a later command fails. Always invoke its paired teardown before clearing hook and temporary state. Closes #1318
JesusValeraDev
approved these changes
Aug 19, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Closes #1318
A failing
set_up_before_scriptskips all tests but previously also skippedtear_down_after_script. Resources acquired before a later setup command failed were left behind.Changes
tear_down_after_scriptbefore clearing file hooks and script-scoped temporary state when setup failsVerification
./bashunit -s -p --skip-env-file tests/acceptance/bashunit_setup_before_script_error_test.sh tests/acceptance/bashunit_bench_test.sh(12 tests, 46 assertions)make samake lintmake docs/buildgit diff --checkChecklist
CHANGELOG.mdto reflect the fix