Skip to content

fix: No error is thrown when adding plug-ins repeatedly. #846 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2018
Merged

fix: No error is thrown when adding plug-ins repeatedly. #846 #847

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
625c429
fix: No error is thrown when adding plug-ins repeatedly. #846
Houfeng Aug 28, 2018
2efa87f
return already added component
aciccarello Oct 4, 2018
46e9327
add typecast
aciccarello Oct 4, 2018
9fe3aed
add actual typecast
aciccarello Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/utils/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,10 @@ export abstract class ChildableComponent<O extends ComponentHost, C extends Comp
}

if (this._componentChildren[name]) {
throw new Error('The component `%s` has already been added.');
// Component already added so we will return the existing component
// TODO: add better logging around this because it could be unexpected but shouldn't be fatal
// See https://github.com/TypeStrong/typedoc/issues/846
return <T> this._componentChildren[name];
} else {
const component: T = typeof componentClass === 'function'
? new (<ComponentClass<T>> componentClass)(this)
Expand Down