Default theme: Tag-based visibilityFilter supports signatures#2846
Merged
Gerrit0 merged 2 commits intoTypeStrong:devfrom Feb 9, 2025
Merged
Default theme: Tag-based visibilityFilter supports signatures#2846Gerrit0 merged 2 commits intoTypeStrong:devfrom
Gerrit0 merged 2 commits intoTypeStrong:devfrom
Conversation
Gerrit0
requested changes
Feb 9, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Introduces the capability to apply visibility filters based on (modifier) tags at the method signature, accessor signature, and index signature levels.
If visibility of every signature is affected by the same tag, this influence is now elevated to the method or accessor itself. This change ensures that when all signatures of a method/accessor are filtered out (hidden), the method/accessor title will also be hidden accordingly. This modification addresses the issue where method/accessor titles were still visible even though all their signatures were hidden.
Previously, the visibility of index signature container element was determined by whether the class they belonged to met the filter criteria. This behavior has been altered so that these container elements are no longer influenced by the filter settings.
Known Issues
DeclarationReflectionof an index signatureSignatureReflectionis the class it belongs to, instead of any method or propertyDeclarationReflection. ClassDeclarationReflectionis notInheritable, since it cannot be a member of class/interface.