Skip to content

Default theme: Tag-based visibilityFilter supports signatures #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

XeroAlpha
Copy link
Contributor

Changes

  1. Introduces the capability to apply visibility filters based on (modifier) tags at the method signature, accessor signature, and index signature levels.

  2. If visibility of every signature is affected by the same tag, this influence is now elevated to the method or accessor itself. This change ensures that when all signatures of a method/accessor are filtered out (hidden), the method/accessor title will also be hidden accordingly. This modification addresses the issue where method/accessor titles were still visible even though all their signatures were hidden.

  3. Previously, the visibility of index signature container element was determined by whether the class they belonged to met the filter criteria. This behavior has been altered so that these container elements are no longer influenced by the filter settings.

Known Issues

  • Index signatures do not support "Inherited" and "External" filters. This limitation arises because the parent DeclarationReflection of an index signature SignatureReflection is the class it belongs to, instead of any method or property DeclarationReflection. Class DeclarationReflection is not Inheritable, since it cannot be a member of class/interface.

@Gerrit0 Gerrit0 merged commit 4e1266f into TypeStrong:dev Feb 9, 2025
8 checks passed
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 9, 2025

Thanks!

@Gerrit0 Gerrit0 added this to the v0.27.8 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants