Fix bug of TS_NODE_TYPE_CHECK and TS_NODE_CACHE not taking effect #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug of the environment variables
TS_NODE_TYPE_CHECKandTS_NODE_CACHEnot taking effect.This is because
cacheandtypeCheckare set tonullby default, sooptions.cache === undefinedandoptions.typeCheck === undefinedare never evaluated to true.I thought of setting the default values to
undefined, butminimistsets undefined options to the default values of their types, which isfalse.So, I ended up negating
option.cacheandoptions.typeCheck, though I don't know this is the best choice.