Skip to content

Disable detaching sub-process on Windows #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Disable detaching sub-process on Windows #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ v8flags(function (err, v8flags) {
// are propagated to the process tree, but `kill` is not.
//
// See: https://nodejs.org/api/child_process.html#child_process_options_detached
detached: true,
//
// This fix is not being required on Windows; besides, detached mode
// runs differently on Windows than on other platforms, and it would break
// the behavior of this application. See https://github.com/TypeStrong/ts-node/issues/480
// for more details.
detached: process.platform !== 'win32',
stdio: 'inherit'
}
)
Expand Down