Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there's way too many examples #899

Merged
merged 7 commits into from
Jan 19, 2019
Merged

Conversation

johnnyreilly
Copy link
Member

@johnnyreilly johnnyreilly commented Jan 19, 2019

look to remove most of them in order to make getting started less daunting. Fixes #888

@kenotron I believe that the fork-ts-checker-webpack-plugin example in this PR may actually be better for incremental builds than your own fast-incremental-builds as it uses the new watch API. I'd like to consolidate the two examples into one really. I'd appreciate your help if you can advise?

Side note: @kenotron - I think that you might want to check out the useTypescriptIncrementalApi feature of fork-ts-checker-webpack-plugin for the improvement to your own dev workflow it can offer.

Details here: https://blog.johnnyreilly.com/2019/01/typescript-and-webpack-watch-it.html
See also: TypeStrong/fork-ts-checker-webpack-plugin#198

@johnnyreilly johnnyreilly merged commit 4551893 into master Jan 19, 2019
@johnnyreilly johnnyreilly deleted the feature/simplify-examples branch January 19, 2019 10:48
@donaldpipowitch
Copy link
Contributor

About the fast-incremental-builds example. I saw you used experimentalWatchApi: true for the ts-loader, but not useTypescriptIncrementalApi: true for ForkTsCheckerWebpackPlugin. Do I only need one of them? Do you know if the watch setting of ForkTsCheckerWebpackPlugin should still be used with the incremental API? ("Directories or files to watch by service. Not necessary but improves performance")

@johnnyreilly
Copy link
Member Author

the fast-incremental-builds example

It predates the useTypescriptIncrementalApi: true being available in the fork-ts-checker-webpack-plugin. I'm thinking of removing the fast-incremental-builds example as it's no longer that.

The experimentalWatchApi: true has never worked as well as hoped; I'm not sure it performs significantly better and problems with it have been reported.

Do I only need one of them?

They're different things - one for the loader and one for the type checker. I'd only bother with the plugin option myself.

Do you know if the watch setting of ForkTsCheckerWebpackPlugin should still be used with the incremental API?

It's not used in the case of the incremental API; if supplied it is ignored.

@donaldpipowitch
Copy link
Contributor

Thank you for the explanation!

ybiquitous added a commit to ybiquitous/ts-loader that referenced this pull request Jul 24, 2019
These missing examples were removed in PR TypeStrong#899.
johnnyreilly pushed a commit that referenced this pull request Jul 24, 2019
These missing examples were removed in PR #899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants