Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invalid files in tsconfig.json super obvious when ts-loader errors #145

Merged
merged 3 commits into from
Jan 26, 2016
Merged

Make invalid files in tsconfig.json super obvious when ts-loader errors #145

merged 3 commits into from
Jan 26, 2016

Conversation

johnnyreilly
Copy link
Member

Hey @jbrantly

This PR is to mitigate the problems of #117 - invalid files in tsconfig.json will be very obvious as a result of the change to error message. Hope you like it; happy to tweak further. I've added a test as well.

@jbrantly
Copy link
Member

Beautiful! Thanks for this. The test is currently failing on TS 1.8 (cause of the changes in TS 1.8 to add "use strict" to output). As a quick note, you can could either update manually or....

npm install typescript@next
npm test -- --save-output

That will update the test cases with the actual output. Then you just need to review the output using git diff and you're good to go.

As far as actual functionality, 👍

@johnnyreilly
Copy link
Member Author

Thanks chap - I submitted the PR and then turned off my computer (foolishly assuming the build would pass 😄). I'll fix and commit when I get a moment.

jbrantly added a commit that referenced this pull request Jan 26, 2016
Make invalid files in tsconfig.json super obvious when ts-loader errors
@jbrantly jbrantly merged commit 2eab312 into TypeStrong:master Jan 26, 2016
@jbrantly
Copy link
Member

Thanks again!

@johnnyreilly
Copy link
Member Author

My pleasure!

@jkillian
Copy link

👍 Great change! This was throwing me for a loop today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants