Fixes the method by which the location of typedoc's executable is locate... #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated
- `require.resolve('<module name>/package.json')` will properly locate the path to an npm module
- we must find `package.json` specifically because it is guaranteed to
exist in the module's root. It's possible that a
module's `package.json` declares `"main": "lib/subdir/index.js"`
|
+100 to get this merged in |
vvakame
added a commit
that referenced
this pull request
Mar 29, 2015
Fixes the method by which the location of typedoc's executable is locate...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.
By using require.resolve to locate typedoc's package.json, we can reliably find the root directory of typedoc. Then we ascend up a directory, descend into .bin, and we've found typedoc's executable.