-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue files are not type checked or linted with useTypescriptIncrementalApi #219
Comments
Thanks for reporting. We have integration tests that check that Vue errors etc are caught: Could you compare your setup with this please? I'm keen we understand why you might not be picking up errors with your config. It might help you're able to produce a minimal reproduction of the issue and then compare that to our integration tests. Neither myself or the implementors of this support are Vue users and so we may benefit from assistance with this. 😉 Any help you can provide would be greatly appreciated! |
Thanks for the answer. I can't really find a big difference when it comes to configuration but it seems there is no test that checks for type and linting errors directly in *.vue files (or I missed that). I made a sample project here:
In that code results with:
Even so the ./scripts/components/HelloWorld.vue file contains a type error. |
Thanks so much for that. I think you may have identified a bug. If you (or anyone else) is able to take a look I'd greatly appreciate the assistance. In the meantime I'll change the plugin so it doesn't default to use the incremental API with Vue projects. I'll make we get that in for the 1.0.0 release. |
I had a fresh look at the tests, and vue tests for useTypescriptIncrementalApi are quite poor - there is only one test actually testing for errors and it is wrong (there should 2 errors, not 1). |
Completely agree @0xorial. I believe @WolfspiritM has been working on trying to fix the issue here: #220 I'm not too sure how things are going. |
@WolfspiritM |
Hi,
My config is:
Using that config an error I implemented in a vue file is not checked:
e.g.:
Does not produce any error.
Changing useTypescriptIncrementalApi to false works but is much slower.
The text was updated successfully, but these errors were encountered: