Added deprecated section to annotation docs

[lolleko]

Should be merged once a new version with the changes from TypeScriptToLua/TypeScriptToLua#949 is released

TODO:

• add instructions for pureabstract (Dota example)
• instructions for phantom?
• instructions for extension (same as pureabstract?)
• metaextension (same as pureabstract but with debug.getregistry)

[hazzard993]

Suggested change

	<DeprecatedInVersion deprecated="0.37.0" removed="TBD"></DeprecatedInVersion>
	<DeprecatedInVersion deprecated="0.37.0" removed="TBD" />

There are multiple lines like this one which should be changed if this change is acceptable

[hazzard993]

Suggested change

	export function SmallCallout({ children, serverity = "warning" }: { children: React.ReactNode; serverity: string }) {
	export function SmallCallout({ children, severity = "warning" }: { children: React.ReactNode; severity?: string }) {

• Spell check serverity -> severity
• Severity has a default value, but is considered to be required
  • The default value is never actually used so the default could be removed, or the severity be required

If this line is becoming too long this is another common TSX syntax I see used, but it isn't used in this codebase

type Props = {
  children: React.ReactNode;
  severity?: string;
};

export const SmallCallout: React.FC<Props> = ({ children, severity = "warning" }) => {
  return (...);
};

[hazzard993]

Just wondering what happened to the sideBySide whilst making these changes

[lolleko]

I disliked how long lines inside sidebyside would cause this ugly overflow and really small right/left sides. Now it wraps if there is not enough space to display both elements in one row. Similar to how it wraps on mobile devices.

Before:

Now:

[lolleko]

Oh and <DeprecatedInVersion> looks like this:

[hazzard993]

Ah okay, good change, thanks for the pictures 👍

[Perryvw]

Why did you go with this over

interface ExistingClass {
    myFunction(): void;
}
ExistingClassTable.myFunction = function() {};

(For example ExistingClass = CDotaGameRules and ExistingClassTable = GameRules (already exists))

[lolleko]

Updated to your example.

[Perryvw]

Suggested change

	The docs are only valid for older versions and include some instructions on how to replace the annotations with vanilla TS.
	Below are the deprecated annotations and instructions to recreate their behavior with vanilla TypeScript.

[Perryvw]

Upgrade instructions: Use ECMAScript modules and import/export. Alternatively, use a real (non-phantom) namespace.

[Perryvw]

Maybe mention preferred is to declare interfaces over classes, otherwise use the the TS below.