Skip to content

WI #1837 Add Violation class #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

WI #1837 Add Violation class #1838

merged 1 commit into from
Jan 5, 2021

Conversation

@fm-117
Copy link
Contributor

@fm-117 fm-117 commented Dec 29, 2020

Minimal implementation of Violation concept :

  • no change in API, violations are still handled as regular diagnostics through the whole process
  • the new Violation class can be used by analyzer implementers to represent a quality rule violation
  • RuleId is transported as 'source' in LSP diagnostic object
  • all rule violations are identified by the same reserved 'code' (47)

@fm-117 fm-117 added this to the Code Quality milestone Dec 29, 2020
@fm-117 fm-117 self-assigned this Dec 29, 2020
@fm-117 fm-117 linked an issue Dec 30, 2020 that may be closed by this pull request
Add Rules and Violations concepts to the parser #1837
Closed
@fm-117 fm-117 merged commit 97936bc into 1816_NewExecutionStep_QualityCheck Jan 5, 2021
@fm-117 fm-117 deleted the 1837_AddRulesViolations branch January 5, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayanje mayanje Awaiting requested review from mayanje

3 more reviewers

@smedilol smedilol smedilol approved these changes

@rooksdo rooksdo rooksdo approved these changes

@delevoye delevoye delevoye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fm-117 fm-117

Labels

Enhancement

Projects

None yet

Milestone

Code Quality

Development

Successfully merging this pull request may close these issues.

Add Rules and Violations concepts to the parser

5 participants

@fm-117 @smedilol @rooksdo @delevoye