1791 initial value and continuation lines #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayanje
previously approved these changes
Nov 12, 2020
This was
linked to
issues
Nov 16, 2020
Closed
Base automatically changed from
1777_comments_mixed_with_continuationlines
to
develop
November 19, 2020 14:30
# Conflicts: # TypeCobol/Compiler/Scanner/Scanner.cs # TypeCobol/Compiler/Scanner/ScannerStep.cs
rooksdo
reviewed
Nov 24, 2020
Codegen/test/resources/output/TypeCobol/GenContinueInsideTypdef.rdz.tcbl
Show resolved
Hide resolved
rooksdo
reviewed
Nov 24, 2020
TypeCobol.Test/Parser/Programs/Cobol85/ContinuationLine/ContinuationPictureString.rdzMix.txt
Outdated
Show resolved
Hide resolved
rooksdo
reviewed
Nov 24, 2020
smedilol
approved these changes
Nov 30, 2020
rooksdo
approved these changes
Nov 30, 2020
mayanje
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Fixes #1671
Fixes #1791
Building upon PR #1790, this new PR addresses bugs during token attribution on continued lines and also handle trailing spaces in continued values so as to create correct initial values.
Important note: this is a breaking change for users ! As demonstrated in GenContinueInsideTypdef codegen test, the generated code is now different and as a consequence the runtime results will also be different. Although the new generated code is correct, users must be warned about this change of behavior.