Repository navigation
Conversation
BlockNote binds the editor to the Yjs document only after the provider reports that it is synced. When the websocket is blocked, the websocket provider never syncs. The http fallback synced the document, but the editor stayed unbound: it accepted text that never reached the document, so the text was not saved. The provider now reports synced after the first http sync. Signed-off-by: yousefed <yousefdardiry@gmail.com>
BlockNote now renders the comment menu in a portal outside the thread, so the test finds its items on the page. The Typst PDF export writes the language as /Lang(fr), without a space. Signed-off-by: yousefed <yousefdardiry@gmail.com>
|
Size Change: 0 B Total Size: 4.23 MB 📦 View Changed
|
When a PDF regression test fails because of an intended change, the report now has the generated PDF. It is the new fixture. Signed-off-by: yousefed <yousefdardiry@gmail.com>
The BlockNote version history sidebar replaced the "Version history" dialog that these tests use. The history also groups edits by at least 5 minutes, so a test cannot create versions. Signed-off-by: yousefed <yousefdardiry@gmail.com>
The fixture was made with an older exporter. The Typst export now also has the emoji, the interlink icon, the diagram, the formula and the image caption, and writes spaces where the fixture had tabs. The new fixture is the PDF that CI generated. Signed-off-by: yousefed <yousefdardiry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the 3 e2e tests that failed on every pull request since the BlockNote preview packages (#2). Before, Playwright stopped after these 3 failures (
maxFailures: 3), so more than 130 other tests did not run.Changes
🐛 Edits were not saved when the websocket is blocked (real bug)
Test: "falls back to http polling when the websocket cannot be opened".
provider.synced, or itssyncedevent).provider.synced = truein the fallback's sync callback). When the websocket connects again, y-websocket controlssynceditself.useProviderStore.test.tsx. It fails without the fix.I found this on the dev instance: with the websocket blocked, the http requests carried only awareness, and the editor's sync plugin had no Yjs type.
✅ Comment menu (test only)
Test: "it checks the comments interactions". BlockNote now renders the comment menu ("Edit comment", "Delete comment") in a portal outside
.bn-thread. The test now finds the menu items on the page.✅ PDF language (test only)
Test: "it injects the correct language attribute into PDF export". The PDF is correct. The Typst export writes
/Lang(fr), without a space. The test expected/Lang (fr). It now accepts both.✅ PDF export regression fixture (test only)
Test: "it exports the doc to PDF and checks regressions". The fixture was made with an older exporter. The Typst export also has the emoji, the interlink icon, the diagram, the formula and the image caption, and it writes spaces where the fixture had tabs. The new fixture is the PDF that CI generated. To make this easy next time, the PDF comparison now attaches the generated PDF to the Playwright report.
⏭️ Version history tests (skipped)
Tests: "it displays the doc versions" and "it restores the doc version". They use the "Version history" dialog, which the BlockNote version history sidebar replaced (#2). Also, the history groups edits by at least 5 minutes, so a test cannot create versions. "it does not display the doc versions if not allowed" still runs.
Not in this PR