Skip to content

fix: node conversion #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 6, 2024
Merged

fix: node conversion #800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
61f3ec7
fix: node conversion
jkcs Jun 4, 2024
fa20a9e
fix \n
jkcs Jun 4, 2024
2399d24
test node conversions
jkcs Jun 4, 2024
3d8e4ee
fix: command `BNUpdateBlock`
jkcs Jun 4, 2024
d4f9fcf
Add a test for customBlock with line breaks.
jkcs Jun 5, 2024
23d1c5b
add test for BNUpdateBlock with line break
jkcs Jun 6, 2024
e03bf15
fix type error
jkcs Jun 6, 2024
38fcd38
Refactored unit tests
matthewlipski Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test for customBlock with line breaks.
  • Loading branch information
@jkcs
jkcs committed Jun 5, 2024
commit d4f9fcf2fad22f3a1c062f954fa37d9ee22a31b0
1 change: 1 addition & 0 deletions packages/core/src/api/exporters/html/__snapshots__/customBlock/basic/external.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="bn-inline-content custom-block" data-editable="">Custom customBlock</div><div class="bn-inline-content custom-block" data-editable="">Custom customBlock <br>with <br>line breaks</div>
1 change: 1 addition & 0 deletions packages/core/src/api/exporters/html/__snapshots__/customBlock/basic/internal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="bn-block-group" data-node-type="blockGroup"><div class="bn-block-outer" data-node-type="blockOuter" data-id="1"><div class="bn-block" data-node-type="blockContainer" data-id="1"><div class="bn-block-content" data-content-type="customBlock"><div class="bn-inline-content custom-block" data-editable="">Custom customBlock</div></div></div></div><div class="bn-block-outer" data-node-type="blockOuter" data-id="2"><div class="bn-block" data-node-type="blockContainer" data-id="2"><div class="bn-block-content" data-content-type="customBlock"><div class="bn-inline-content custom-block" data-editable="">Custom customBlock <br>with <br>line breaks</div></div></div></div></div>
2 changes: 1 addition & 1 deletion packages/core/src/api/exporters/html/__snapshots__/customParagraph/basic/internal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<div class="bn-block-group" data-node-type="blockGroup"><div class="bn-block-outer" data-node-type="blockOuter" data-id="1"><div class="bn-block" data-node-type="blockContainer" data-id="1"><div class="bn-block-content" data-content-type="customParagraph"><p class="bn-inline-content custom-paragraph" data-editable="">Custom Paragraph</p></div></div></div><div class="bn-block-outer" data-node-type="blockOuter" data-id="2"><div class="bn-block" data-node-type="blockContainer" data-id="2"><div class="bn-block-content" data-content-type="customParagraph"><p class="bn-inline-content custom-paragraph" data-editable="">Custom Paragraph with <br>multiple lines</p></div></div></div></div>
<div class="bn-block-group" data-node-type="blockGroup"><div class="bn-block-outer" data-node-type="blockOuter" data-id="1"><div class="bn-block" data-node-type="blockContainer" data-id="1"><div class="bn-block-content" data-content-type="customParagraph"><p class="bn-inline-content custom-paragraph" data-editable="">Custom Paragraph</p></div></div></div></div>
5 changes: 5 additions & 0 deletions ...ges/core/src/api/exporters/markdown/__snapshots__/customBlock/basic/markdown.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Custom customBlock

Custom customBlock\
with\
line breaks
Loading