-
-
Notifications
You must be signed in to change notification settings - Fork 648
feat: Threads sidebar #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Threads sidebar #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/src/editor/BlockNoteEditor.ts
matthewlipski
commented
Mar 17, 2025
YousefED
reviewed
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional sidebar for threads that can be used instead of having the threads float next to their respective marks. The
ThreadsSidebarcomponent can be imported from BlockNote to add the sidebar to any editor - see the docs for more.Screen.Recording.2025-03-19.at.10.53.32-1.mov
BlockNoteViewchangesThe
ThreadsSidebarcomponent sits outside the editor but needs to have access to the editor context, including Mantine and theme variables. To do this, I modified whatBlockNoteViewandBlockNoteViewEditorrender whenrenderEditoris false - here's an explanation for what's changed:Previously:
BlockNoteView: Only provides context, doesn't render any elements.BlockNoteViewEditor: Renders bothbn-containerandbn-editorelements.Now:
BlockNoteView: Rendersbn-containerelement.BlockNoteViewEditor: Rendersbn-editorelement.Since Mantine and theme variables are set on the
bn-containerelement, this ensures that anything withinBlockNoteViewis styled properly. It's also worth noting that theme variables are used by thereactpackage, and so we can't really make a similar change to e.g. the Mantine-specificBlockNoteViewinstead.This change should not change anything when
renderEditoris true or undefined.