Remove blank line under a 'none' content block will remove 'none' block together #605

Activity

1. tcper

   added

   bug

   on Mar 5, 2024
2. matthewlipski

   added

   prio:mid

   on Jun 11, 2024
3. sb8244 commented on Aug 12, 2024

   

   sb8244

   on Aug 12, 2024

   More actions

   Is the solution here to check if the block is paragraph, has no content, and focus is start of block (should be impossible to meet these criteria and not meet this one). If that matches, then delete the block rather than merging it?
4. matthewlipski commented on Aug 27, 2024

   

   matthewlipski

   on Aug 27, 2024

   Last edited by matthewlipski

   Collaborator

   More actions

   Yeah that sounds right - we should already have quite some backspace handling logic here for that, but seems like this case isn't accounted for
5. sb8244 commented on Aug 27, 2024

   

   sb8244

   on Aug 27, 2024

   More actions

   @matthewlipski I'm not sure any of the code blocks there handle that cases this. At least when I looked into it, I came to that conclusion.

   I wrote some custom keydown handlers (on BlockNoteView) that handle this case and another. One big thing here is pulling the children from the block to the prevBlock:

   if (e.key === "Backspace") {
             const selection = blockNoteEditor.getSelection()
             const position = blockNoteEditor.getTextCursorPosition()
   
             if (selection === undefined && position && position.block.type === "paragraph") {
               const block = position.block
               const blockPos = getBlockInfoFromPos(
                 blockNoteEditor._tiptapEditor.state.doc,
                 blockNoteEditor._tiptapEditor.state.selection.anchor
               )
   
               const isTopBlock = blockPos.depth === 2
               const isEmptyBlock = block.content.length === 0 && block.children.length === 0
               const isEmptyContentWithChildren = block.content.length === 0 && block.children.length > 0
   
               if (isTopBlock && isEmptyBlock) {
                 e.stopPropagation()
                 e.preventDefault()
                 blockNoteEditor.removeBlocks([block])
   
                 if (position.prevBlock) {
                   blockNoteEditor.setTextCursorPosition(position.prevBlock, "end")
                 }
               } else if (isTopBlock && position.prevBlock && isEmptyContentWithChildren && Array.isArray(position.prevBlock.children)) {
                 e.stopPropagation()
                 e.preventDefault()
                 blockNoteEditor.updateBlock(position.prevBlock, { children: position.prevBlock.children.concat(block.children) })
                 blockNoteEditor.removeBlocks([block])
   
                 if (position.prevBlock) {
                   blockNoteEditor.setTextCursorPosition(position.prevBlock, "end")
                 }
               }
             }
           }
6. matthewlipski commented on Aug 28, 2024

   

   matthewlipski

   on Aug 28, 2024

   Collaborator

   More actions

   Hmm have you tried modifying the code from BNMergeBlocks? I think if you just remove the .replace here, you should get pretty close to the correct behaviour. The difference is that BNMergeBlocks will just un-nest the children of the later block, rather than attaching them to the previous one which might still be a dealbreaker. Either way I think it's smth you might want to look into
7. lamtuanamc commented on Nov 25, 2024

   

   lamtuanamc

   on Nov 25, 2024

   Last edited by lamtuanamc

   More actions

   Hi @matthewlipski, I've created a pull request to resolve this issue. Could you please review it at your convenience? Thank you!
8. matthewlipski

   closed this as completedin #1505on Mar 19, 2025